If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Consolidate value for new_tablet_browser_toolbar_height

NEW
Unassigned

Status

()

Firefox for Android
General
3 years ago
3 years ago

People

(Reporter: mcomella, Unassigned)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
We set the ActionBarViewFlipper height with new_tablet_browser_toolbar_height (60dp) but all other uses of browser_height on tablet are using the values-large-v11/dimens.xml value of 56dp. That means we've been using different height values all along! Oops!

omgbbq! Fix it!
(Reporter)

Comment 1

3 years ago
I changed this value to browser_toolbar_height_flipper in bug 1106935.
(Reporter)

Comment 2

3 years ago
Created attachment 8588246 [details]
ActionBar

Found the first case where this breaks - notice the gap below the tapped button and the bottom of the toolbar?
Shouldn't the Action Bar also be displayed on top of the tabs UI (and therefore hiding it?) I remember discussing this before but maybe we didn't close that bug.
Flags: needinfo?(michael.l.comella)
(Reporter)

Comment 4

3 years ago
(In reply to Anthony Lam (:antlam) from comment #3)
> Shouldn't the Action Bar also be displayed on top of the tabs UI (and
> therefore hiding it?) I remember discussing this before but maybe we didn't
> close that bug.

bug 1122056.
Flags: needinfo?(michael.l.comella)
(Reporter)

Comment 5

3 years ago
The image in comment 2 is just an example where we used the wrong value though, and the effect it has. There can be other issues too.
You need to log in before you can comment on or make changes to this bug.