Closed
Bug 1150761
Opened 9 years ago
Closed 9 years ago
Rename Details Views
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect)
Tracking
(firefox40 verified, firefox41 fixed)
VERIFIED
FIXED
Firefox 41
People
(Reporter: fitzgen, Assigned: jsantell)
References
Details
Attachments
(1 file, 1 obsolete file)
2.83 KB,
patch
|
jsantell
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Once bug 1108843 lands we won't only be showing JS here and the biggest differentiator it has from the flame graph is that it is a tree/table rather than a visualization. They both show pretty much the same data so it isn't fair to say one is "JavaScript" but the other isn't. Either way, it isn't super descriptive. "Call Tree" ? "Functions Tree" ? "Functions Table" ? Simply "Table" or "Tree" ?
Assignee | ||
Comment 1•9 years ago
|
||
Whatever we call it, we would also probably need to update the "JS Flame Chart" as well -- we name the other two views "Allocations" and "Allocations Flame Chart" -- what do the "JavaScript" and "JS Flame Chart" have in common to call that? Chrome categorizes these as "JavaScript CPU Profiles" but I think we can name it something more accurate.
Reporter | ||
Comment 2•9 years ago
|
||
The JS ones just have time as their x-axis / time as the thing being profiled. The allocations ones (should) have allocations as the thing being profiled, but I think it doesn't do the right thing right now.
Assignee | ||
Comment 3•9 years ago
|
||
If we're doing this, we need to rename this now for 40.1 and get strings in before Fx40.
Assignee | ||
Comment 5•9 years ago
|
||
Moving "Timeline" renaming bug 1166499 here. Read that for previous discussions. My vote is for Waterfall, Call Tree and Flame Chart. These describe the presentation of the data, as they are all the same source (marker vs sampler data is a black box, and we do not reveal this to the end user). "Timeline" conflicts with the *main timeline that controls all views and used for scrubbing and selecting*, and "JavaScript" doesn't tell me much more about the data -- it's obviously JS (or pseudoframes but whatever). When we introduce allocations views, those can be "Allocation Tree" and "Allocation Flame" (because ideally we'll have flame GRAPHS as well, and can toggle between them).
Blocks: perf-tool-v2
Summary: Rename "JavaScript" tab to "Call Tree" or something → Rename Details Views
Whiteboard: [devedition-40]
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → jsantell
Status: NEW → ASSIGNED
Comment 6•9 years ago
|
||
I'll throw my vote in for Waterfall, call tree and flame chart. It's very intuitive.
Assignee | ||
Updated•9 years ago
|
Blocks: perf-40-uplifts
Assignee | ||
Comment 7•9 years ago
|
||
Barring any changes, we should try to land this before week's end for the screencasts
Attachment #8609202 -
Flags: review?(vporof)
Comment 8•9 years ago
|
||
Comment on attachment 8609202 [details] [diff] [review] 1150761-rename-details-view.patch Review of attachment 8609202 [details] [diff] [review]: ----------------------------------------------------------------- How about renaming the memory columns too while we're here?
Attachment #8609202 -
Flags: review?(vporof) → review+
Assignee | ||
Comment 9•9 years ago
|
||
Allocations Call Tree and Allocations Flame Chart?
Comment 10•9 years ago
|
||
Allocations Tree and Allocations Chart.
Reporter | ||
Comment 11•9 years ago
|
||
(In reply to Victor Porof [:vporof][:vp] from comment #10) > Allocations Tree and Allocations Chart. Yeah, +1
Assignee | ||
Comment 12•9 years ago
|
||
Added allocation naming
Attachment #8609202 -
Attachment is obsolete: true
Attachment #8609515 -
Flags: review+
Comment 13•9 years ago
|
||
(In reply to Victor Porof [:vporof][:vp] from comment #10) > Allocations Tree and Allocations Chart. +2
Assignee | ||
Updated•9 years ago
|
Whiteboard: [devedition-40] → [devedition-40][fixed-in-fx-team]
Comment 15•9 years ago
|
||
Is the plan to land another patch on m-c (but not to be uplifted) that properly changes these strings? May be easiest to open another bug for that and not mark it as blocking the uplift bug.
Flags: needinfo?(jsantell)
Assignee | ||
Comment 16•9 years ago
|
||
Added another entry in the l10n meta bug noting these changes -- don't want to deal with more merging issues for a potential 3 weeks headstart on these strings, more heartache for minimal gain
Flags: needinfo?(jsantell)
Assignee | ||
Comment 17•9 years ago
|
||
Yes, land on mc but post June 2nd to reduce heartache for minimal gain. Noted already in the meta l10n bug
Comment 18•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1c539a7eb9b2
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox41:
--- → fixed
Resolution: --- → FIXED
Whiteboard: [devedition-40][fixed-in-fx-team] → [devedition-40]
Target Milestone: --- → Firefox 41
Updated•9 years ago
|
Flags: qe-verify+
Comment 19•9 years ago
|
||
Comment on attachment 8609515 [details] [diff] [review] 1150761-rename-details-view.patch Approval Request Comment [Feature/regressing bug #]: 1167252, the new performance tool [User impact if declined]: Won't ship the performance tool [Describe test coverage new/current, TreeHerder]: There are try pushes in Bug 1167252 with all patches needing uplift [Risks and why]: Requesting uplift for the accumulated changes in the performance tool since the 40 merge date, so these changes haven't had the full 6 weeks to bake. Risks are generally contained within devtools, specifically within the performance panel. [String/UUID change made/needed]: None
Attachment #8609515 -
Flags: approval-mozilla-aurora?
Comment 20•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/7bc05d558a2d
status-firefox40:
--- → fixed
Comment 21•9 years ago
|
||
Note: I had verbal confirmation for these uplifts from Sylvestre even before he's flagged them as a+. See https://bugzilla.mozilla.org/show_bug.cgi?id=1167252#c26
Comment 22•9 years ago
|
||
Comment on attachment 8609515 [details] [diff] [review] 1150761-rename-details-view.patch Change approved to skip one train as part of the spring campaign.
Attachment #8609515 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 23•9 years ago
|
||
Verified fixed on Aurora 40.0a2 (2015-06-08), using Windows 7 (x64), Ubuntu 14.04 (x64) and Mac OS X 10.9.5. The detailed views from the Performance section are now called "Waterfall", "Call Tree" and "Flame Chart".
Updated•9 years ago
|
Whiteboard: [devedition-40] → [polish-backlog]
Updated•9 years ago
|
Whiteboard: [polish-backlog]
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•