bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

Split up js1_8_5/reflect-parse/destructuring.js

RESOLVED FIXED in Firefox 40

Status

()

Core
JavaScript Engine
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Waldo, Assigned: Waldo)

Tracking

unspecified
mozilla40
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

3 years ago
Astonishingly this test takes something like 33s or so to run, *on its own*.  So any splitup at all is valuable.  Let's make at least the simple, obvious splits.  hg cp for the not-changing-stuff win!
(Assignee)

Comment 1

3 years ago
Created attachment 8587795 [details] [diff] [review]
Split for-loop tests out
Attachment #8587795 - Flags: review?(efaustbmo)
(Assignee)

Comment 2

3 years ago
Created attachment 8587796 [details] [diff] [review]
Split the rest of destructuring.js into several smaller destructuring tests

destructuring.js delenda est!
Attachment #8587796 - Flags: review?(efaustbmo)

Comment 3

3 years ago
Comment on attachment 8587795 [details] [diff] [review]
Split for-loop tests out

Review of attachment 8587795 [details] [diff] [review]:
-----------------------------------------------------------------

Wow since the cp, it's a super weird diff. OK
Attachment #8587795 - Flags: review?(efaustbmo) → review+

Comment 4

3 years ago
Comment on attachment 8587796 [details] [diff] [review]
Split the rest of destructuring.js into several smaller destructuring tests

Review of attachment 8587796 [details] [diff] [review]:
-----------------------------------------------------------------

Lgtm.
Attachment #8587796 - Flags: review?(efaustbmo) → review+
https://hg.mozilla.org/mozilla-central/rev/f121a74df469
https://hg.mozilla.org/mozilla-central/rev/61a2535dcdf5
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox40: --- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.