Closed
Bug 1150786
Opened 9 years ago
Closed 9 years ago
Add the localized string and accesskey for "Debug" add-on button
Categories
(Toolkit :: Add-ons Manager, defect)
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: yfdyh000, Assigned: yfdyh000)
References
Details
Attachments
(1 file, 1 obsolete file)
2.83 KB,
patch
|
mossop
:
review+
|
Details | Diff | Splinter Review |
The "Disable" button have "D", so the to "E". Use the Alt+Shift+E to test it in add-on details pane on Windows.
Attachment #8587809 -
Flags: review?(dtownsend)
Comment 1•9 years ago
|
||
Comment on attachment 8587809 [details] [diff] [review] patch v1 Review of attachment 8587809 [details] [diff] [review]: ----------------------------------------------------------------- I think I'd rather go with B or G here. E conflicts with the Enable button and while we never display the two buttons at the same time at the moment we might want to do that in the future to allow for debugging an add-on's startup code.
Attachment #8587809 -
Flags: review?(dtownsend) → review-
You are right. This "B" may to trigger the Bookmarks menu in the past, I hope not many people use it in this interface. p.s. maybe the "U" can also be considered, if we think it is not a commonly shortcut, the like we have &Install.
Attachment #8587809 -
Attachment is obsolete: true
Attachment #8588831 -
Flags: review?(dtownsend)
Comment 3•9 years ago
|
||
Comment on attachment 8588831 [details] [diff] [review] Patch v2 - "B" Review of attachment 8588831 [details] [diff] [review]: ----------------------------------------------------------------- Let's go with this.
Attachment #8588831 -
Flags: review?(dtownsend) → review+
Keywords: checkin-needed
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6d49087d2a35
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•