1150825 - [RTL][Browser]The format of website address is shown wrong in history list.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect, P1)

Description

[Lancy(Leave from Mozilla)]

Attachment: Screenshot_website.png

[1.Description]:
[RTL][v2.2&v3.0][Browser]Browse some website and go back main view, the format of website address is shown wrong in history list, the "/" is shown at left side of website.
See attachment:Screenshot_website.png.

[2.Testing Steps]: 
1.Set your phone language to Arabic and connect to network.
2.Launch Browser and browse some websites.
3.Go back to main view of Browser and observe the history list.

[3.Expected Result]: 
3.The format of website address should be shown correct in history list.

[4.Actual Result]: 
3.The format of website address is shown wrong in history list.

[5.Reproduction build]: 
Flame 2.2 build (Affected):
Build ID               20150402002500
Gaia Revision          1ceca464053dee4a8bf10ea5abeef724d68c2ff2
Gaia Date              2015-04-01 09:49:30
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/427b4da96714
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150402.035057
Firmware Date          Thu Apr  2 03:51:09 EDT 2015
Bootloader             L1TC000118D0

Flame 3.0 build (Affected):
Build ID               20150402160202
Gaia Revision          62042ffcc8c6cca0f51ad23f5c2b979fc153b5a7
Gaia Date              2015-04-02 16:01:42
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/513265a4cbc2
Gecko Version          40.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150402.192125
Firmware Date          Thu Apr  2 19:21:37 EDT 2015
Bootloader             L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,10/10

[7.TCID]: 
15456

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] KevinGrandon:bug_1150825_history_meta_rtl > mozilla-b2g:master

Comment 2

[Kevin Grandon :kgrandon]

(In reply to Autolander from comment #1)
> Created attachment 8588472 [details] [review]
> [gaia] KevinGrandon:bug_1150825_history_meta_rtl > mozilla-b2g:master

Here's a patch that fixes the issue for me, though I'm not sure if this is correct or not. It appears that we display websites names and URLs LTR still, even while in RTL mode. I don't really know enough about the history to know if this is correct or not.

Comment 3

[Kevin Grandon :kgrandon]

Comment on attachment 8588472 [details] [review]
[gaia] KevinGrandon:bug_1150825_history_meta_rtl > mozilla-b2g:master

I'm guessing this happens because it's "user" content, and there also must be some bug I imagine. This seems the fix it, the alternate fix would be a <bdi> tag along with a float: right I assume. Dale - can you take a look if you get a chance? Thanks!

Comment 4

[Dale Harvey (:daleharvey)]

Comment on attachment 8588472 [details] [review]
[gaia] KevinGrandon:bug_1150825_history_meta_rtl > mozilla-b2g:master

This looks good to me, cheers

Comment 5

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/8a9b81adbc1c3ab0772f4a74b58b5a5008ad6c3b

Comment 6

[Kevin Grandon :kgrandon]

Comment on attachment 8588472 [details] [review]
[gaia] KevinGrandon:bug_1150825_history_meta_rtl > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Missing RTL work.
[User impact] if declined: Poor UX in RTL.
[Testing completed]: Manual testing.
[Risk to taking this patch] (and alternatives if risky): Low risk, small CSS change, only for RTL experiences.
[String changes made]: None.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/1392474e20d8283c2e36afc5e33626900f369be5

Comment 8

[Sue]

Attachment: browser_history_pass.png

This issue has been verified successfully on latest build of Flame 2.2/3.0 with the same steps in comment 0.
See attachment:browser_history_pass.png
Rate:0/5

Device: Flame 2.2 (pass)
Build ID               20150407162504
Gaia Revision          ea735c21bfb0d78333213ff0376fce1eac89ead6
Gaia Date              2015-04-07 20:58:15
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/3f86ddb7f719
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150407.195227
Firmware Date          Tue Apr  7 19:52:39 EDT 2015
Bootloader             L1TC000118D0

Device: Flame 3.0 (pass)
Build ID               20150407160201
Gaia Revision          84cbd4391fb7175d5380fa72c04d68873ce77e6d
Gaia Date              2015-04-07 17:33:14
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/078128c2600a
Gecko Version          40.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150407.193600
Firmware Date          Tue Apr  7 19:36:12 EDT 2015
Bootloader             L1TC000118D0