Use the RequestContext of the LoadInfo when dispatching a FetchEvent

RESOLVED INCOMPLETE

Status

()

Core
DOM
RESOLVED INCOMPLETE
3 years ago
3 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
This switches the Request.context attribute of the FetchEvent
member to use the internal RequestContext values on LoadInfos.
With this, the content policy type on those LoadInfos will
not matter as far as what's exposed to Web content is concerned.
(Assignee)

Comment 1

3 years ago
Created attachment 8587921 [details] [diff] [review]
Use the RequestContext of the LoadInfo when dispatching a FetchEvent
Attachment #8587921 - Flags: review?(nsm.nikhil)
(Assignee)

Updated

3 years ago
Assignee: nobody → ehsan
Blocks: 1121157
Depends on: 1149853
Comment on attachment 8587921 [details] [diff] [review]
Use the RequestContext of the LoadInfo when dispatching a FetchEvent

Review of attachment 8587921 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/workers/test/serviceworkers/fetch/context/index.html
@@ +283,5 @@
>        video.appendChild(track);
>        document.documentElement.appendChild(video);
>        navigator.serviceWorker.addEventListener("message", function onMessage(e) {
>          if (e.data.data == "track") {
> +          is(e.data.context, "track", "Expected the track context on a request coming from a track");

Why did this start working due to this patch?
Attachment #8587921 - Flags: review?(nsm.nikhil) → review+
(Assignee)

Comment 3

3 years ago
(In reply to Nikhil Marathe [:nsm] (needinfo? please) from comment #2)
> ::: dom/workers/test/serviceworkers/fetch/context/index.html
> @@ +283,5 @@
> >        video.appendChild(track);
> >        document.documentElement.appendChild(video);
> >        navigator.serviceWorker.addEventListener("message", function onMessage(e) {
> >          if (e.data.data == "track") {
> > +          is(e.data.context, "track", "Expected the track context on a request coming from a track");
> 
> Why did this start working due to this patch?

Because my patches for bug 1149853 pass in the correct RequstContext for track elements, so a switch to using them fixes this test.
(Assignee)

Comment 4

3 years ago
There is nothing more to be done in this bug...
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.