115086 - Deleting bookmarks is slower than it needs to be

Status: RESOLVED EXPIRED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Randell Jesup [:jesup] (needinfo me)]

When deleting large numbers of bookmarks (see bug 52144), it takes a while (25
seconds for the case tested on an dual-450 machine) with the UI locked.

I suspect part of the reason is that as each bookmark is deleted the display was
updated (so it ended up showing N copies of one bookmark until it finished).  I
was running a remote X display where such things are a little slower (though not
slow).  On Import (which only took 11 seconds, and has much more to do) it does
not update the display until all are added.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: jprof of deleting 350K of imported bookmarks

Imported 350K bookmarks, selected the first one, shift-selected the last one,
hit Delete.

75% of the time is spent in nsXULOutlinerBuilder::SelectionChanged(), called 
    from (deep) within nsOutlinerSelection::RowCountChanged() (which accounts
    for almost 90% of the total f+d hits).  Note: I think a realtime jprof
    would show even more here, since it appears to update the screen as it
    deletes each one, at least for those that are visible.
10% of the time (most of it within the above) is spent in
nsScriptSecurityManager::GetObjectPrincipal()

Quite a bit is spend in js_LookupProperty as well.

Comment 2

[Peter Trudelle]

mass-reassign bookmarks & open pref perf bugs from pchen to ben

Comment 3

[Pierre Chanial]

*** Bug 118372 has been marked as a duplicate of this bug. ***

Comment 4

[Pierre Chanial]

*** Bug 138517 has been marked as a duplicate of this bug. ***

Comment 5

[David G King]

With all the code changes that have been happening, can the reporter verify if
this is still a problem?

Apologies to Ben for usurping his role as owner of this bug.

Comment 6

[Robert Kaiser]

MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 7

[Robert Kaiser]

MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but still has no comment since the inception of the SeaMonkey project 5 years ago.

Because of this, we're resolving the bug as EXPIRED.

If you still can reproduce the bug on SeaMonkey 2 or otherwise think it's still valid, please REOPEN it and if it is a platform or toolkit issue, move it to the according component.

Query tag for this change: EXPIRED-20100420