Change the default return type for plugin blocklist queries to STATE_BLOCKED

NEW
Unassigned

Status

()

Core
Plug-ins
3 years ago
3 years ago

People

(Reporter: jimm, Unassigned)

Tracking

Trunk
x86_64
All
Points:
---

Firefox Tracking Flags

(firefox40 affected)

Details

(Reporter)

Description

3 years ago
In bug 1129040 I tried to change all the default blocklist states from not block to blocked. These return results get generated when a query on the BLS fails. In practice in fx, I don't think the blocklist service ever fails a query so this change should not break web content. However this change did break a couple test suites in odd ways, here's a couple examples:

05:35:24 INFO - 2236 INFO TEST-UNEXPECTED-FAIL | dom/plugins/test/mochitest/test_GCrace.html | uncaught exception - TypeError: p.checkGCRace is not a function at http://mochi.test:8888/tests/dom/plugins/test/mochitest/test_GCrace.html:62

05:35:24 INFO - 2242 INFO TEST-UNEXPECTED-FAIL | dom/plugins/test/mochitest/test_NPNVdocumentOrigin.html | uncaught exception - TypeError: p1.getNPNVdocumentOrigin is not a function at http://mochi.test:8888/tests/dom/plugins/test/mochitest/test_NPNVdocumentOrigin.html:18 

We should dig into this and understand why our tests rely on a return result that should never be returned. After which we should be able to land a patch that changes any and all BLS defaults to STATE_BLOCKED.
(Reporter)

Updated

3 years ago
OS: Windows 7 → All
You need to log in before you can comment on or make changes to this bug.