Closed
Bug 1150867
Opened 9 years ago
Closed 9 years ago
Get rid of the browser-aero.css override
Categories
(Firefox :: Theme, defect)
Firefox
Theme
Tracking
()
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: dao, Assigned: dao)
References
Details
Attachments
(1 file)
26.20 KB,
patch
|
Gijs
:
review+
|
Details | Diff | Splinter Review |
I decided it's ok to bitrot bug 1147702, I'll just update the patch there. I was able to keep this patch minimal by %including browser-aero.css into browser.css, but eventually we should merge browser-aero.css into browser.css and move each rule from the end of the file to a place where it makes the most sense.
Comment 1•9 years ago
|
||
Comment on attachment 8587929 [details] [diff] [review] patch Review of attachment 8587929 [details] [diff] [review]: ----------------------------------------------------------------- Nice. ::: browser/themes/windows/browser.css @@ +359,1 @@ > margin-left: 22px; /* additional space for Aero Snap */ Nit: I'd prefer it if the XP case was before this one, but obviously that doesn't work because CSS order-of-rules-is-important-ness. Given that, can you update this comment to "need some space for Aero snap" and add another one below to say something like "need less space on XP because there's no Aero snap" or whatever?
Attachment #8587929 -
Flags: review?(gijskruitbosch+bugs) → review+
Assignee | ||
Comment 2•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/e09897c3304b
Comment 3•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e09897c3304b
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
You need to log in
before you can comment on or make changes to this bug.
Description
•