Get rid of the browser-aero.css override

RESOLVED FIXED in Firefox 40

Status

()

Firefox
Theme
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

Trunk
Firefox 40
Points:
3
Dependency tree / graph
Bug Flags:
firefox-backlog +
qe-verify -

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8587929 [details] [diff] [review]
patch

I decided it's ok to bitrot bug 1147702, I'll just update the patch there.

I was able to keep this patch minimal by %including browser-aero.css into browser.css, but eventually we should merge browser-aero.css into browser.css and move each rule from the end of the file to a place where it makes the most sense.
Attachment #8587929 - Flags: review?(gijskruitbosch+bugs)
Flags: qe-verify-
Flags: firefox-backlog+

Comment 1

3 years ago
Comment on attachment 8587929 [details] [diff] [review]
patch

Review of attachment 8587929 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.

::: browser/themes/windows/browser.css
@@ +359,1 @@
>    margin-left: 22px; /* additional space for Aero Snap */

Nit: I'd prefer it if the XP case was before this one, but obviously that doesn't work because CSS order-of-rules-is-important-ness. Given that, can you update this comment to "need some space for Aero snap" and add another one below to say something like "need less space on XP because there's no Aero snap" or whatever?
Attachment #8587929 - Flags: review?(gijskruitbosch+bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/e09897c3304b
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox40: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40

Updated

3 years ago
Depends on: 1154218
(Assignee)

Updated

3 years ago
No longer depends on: 1154218
(Assignee)

Updated

3 years ago
Blocks: 1154233
(Assignee)

Updated

3 years ago
Blocks: 1154625
You need to log in before you can comment on or make changes to this bug.