1150872 - Update toast notification when removing a page from reading list from reader view toolbar

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Reading List, defect)

Description

[Teodora Vermesan (:TeoVermesan)]

Steps to reproduce:
1. Open an article from news.google.com and enter reader view
2. Add the article to reading list
3. Tap the "add to reading list" icon from the reader mode toolbar
4. Tap the "remove from reading list" (garbage icon) from the reader mode toolbar

Actual results:
- After step 3, a notification is displayed: "Page added to your reading list"
- After step 4, a notification is displayed: "Page removed"

Expected results:
- After step 4, a notification should be displayed: "Page removed from your reading list"

Note: 
- when choosing to remove a page from reading list from the Custom Menu, the notification "Page removed from your reading list" is also displayed

Comment 1

[:Margaret Leibovic]

Attachment: MozReview Request: bz://1150872/margaret

/r/6595 - Bug 1150872 - Update toast notification when removing a page from reading list from reader view toolbar. r=mcomella

Pull down this commit:

hg pull -r fa4250573111a76573f9f46821678b60f31e07f1 https://reviewboard-hg.mozilla.org/gecko/

Comment 2

[:Margaret Leibovic]

Comment on attachment 8587968 [details]
MozReview Request: bz://1150872/margaret

/r/6595 - Bug 1150872 - Update toast notification when removing a page from reading list from reader view toolbar. r=mcomella

Pull down this commit:

hg pull -r fa4250573111a76573f9f46821678b60f31e07f1 https://reviewboard-hg.mozilla.org/gecko/

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8587968 [details]
MozReview Request: bz://1150872/margaret

https://reviewboard.mozilla.org/r/6593/#review5479

Ship It!

Comment 4

[:Margaret Leibovic]

Comment on attachment 8587968 [details]
MozReview Request: bz://1150872/margaret

Approval Request Comment
[Feature/regressing bug #]: bug 1127445
[User impact if declined]: toast messages are inconsistent when removing an item from your reading list
[Describe test coverage new/current, TreeHerder]: tested locally, just landed on fx-team
[Risks and why]: very low risk string swap
[String/UUID change made/needed]: none (the entity already existed for the other toast notification where we show this message)

Comment 5

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/97af68bc45d5

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/97af68bc45d5

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8587968 [details]
MozReview Request: bz://1150872/margaret

Should be in 38 beta 4

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/26a4b69f52b9

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/3f5d7f277471

Comment 10

[Teodora Vermesan (:TeoVermesan)]

After tapping the garbage icon from the reader view toolbar, "Page removed from your reading list" notification is displayed.
Verified as fixed on:
Device: Samsung S 5 (Android 4.4)
Builds: Firefox for Android 39.0a2 (2015-04-08) and Firefox for Android 40.0a1 (2015-04-07)

Comment 11

[Catalin Suciu [:csuciu]]

The bug is fixed on Beta 38.0b3 also.
Verifying.

Comment 13

[:Margaret Leibovic]

Attachment: MozReview Request: Bug 1150872 - Update toast notification when removing a page from reading list from reader view toolbar. r=mcomella