Update toast notification when removing a page from reading list from reader view toolbar

VERIFIED FIXED in Firefox 40

Status

VERIFIED FIXED
4 years ago
8 months ago

People

(Reporter: TeoVermesan, Assigned: Margaret)

Tracking

Trunk
Firefox 40
ARM
Android

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

4 years ago
Steps to reproduce:
1. Open an article from news.google.com and enter reader view
2. Add the article to reading list
3. Tap the "add to reading list" icon from the reader mode toolbar
4. Tap the "remove from reading list" (garbage icon) from the reader mode toolbar

Actual results:
- After step 3, a notification is displayed: "Page added to your reading list"
- After step 4, a notification is displayed: "Page removed"

Expected results:
- After step 4, a notification should be displayed: "Page removed from your reading list"

Note: 
- when choosing to remove a page from reading list from the Custom Menu, the notification "Page removed from your reading list" is also displayed
(Reporter)

Updated

4 years ago
Component: Reader View → Reading List
(Assignee)

Comment 1

4 years ago
/r/6595 - Bug 1150872 - Update toast notification when removing a page from reading list from reader view toolbar. r=mcomella

Pull down this commit:

hg pull -r fa4250573111a76573f9f46821678b60f31e07f1 https://reviewboard-hg.mozilla.org/gecko/
Attachment #8587968 - Flags: review?(michael.l.comella)
(Assignee)

Comment 2

4 years ago
Comment on attachment 8587968 [details]
MozReview Request: bz://1150872/margaret

/r/6595 - Bug 1150872 - Update toast notification when removing a page from reading list from reader view toolbar. r=mcomella

Pull down this commit:

hg pull -r fa4250573111a76573f9f46821678b60f31e07f1 https://reviewboard-hg.mozilla.org/gecko/
(Assignee)

Updated

4 years ago
Assignee: nobody → margaret.leibovic
status-firefox38: --- → affected
status-firefox39: --- → affected
Comment on attachment 8587968 [details]
MozReview Request: bz://1150872/margaret

https://reviewboard.mozilla.org/r/6593/#review5479

Ship It!
Attachment #8587968 - Flags: review?(michael.l.comella) → review+
(Assignee)

Comment 4

4 years ago
Comment on attachment 8587968 [details]
MozReview Request: bz://1150872/margaret

Approval Request Comment
[Feature/regressing bug #]: bug 1127445
[User impact if declined]: toast messages are inconsistent when removing an item from your reading list
[Describe test coverage new/current, TreeHerder]: tested locally, just landed on fx-team
[Risks and why]: very low risk string swap
[String/UUID change made/needed]: none (the entity already existed for the other toast notification where we show this message)
Attachment #8587968 - Flags: approval-mozilla-beta?
Attachment #8587968 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/97af68bc45d5
Status: NEW → RESOLVED
Last Resolved: 4 years ago
status-firefox40: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
Comment on attachment 8587968 [details]
MozReview Request: bz://1150872/margaret

Should be in 38 beta 4
Attachment #8587968 - Flags: approval-mozilla-beta?
Attachment #8587968 - Flags: approval-mozilla-beta+
Attachment #8587968 - Flags: approval-mozilla-aurora?
Attachment #8587968 - Flags: approval-mozilla-aurora+
(Reporter)

Comment 10

4 years ago
After tapping the garbage icon from the reader view toolbar, "Page removed from your reading list" notification is displayed.
Verified as fixed on:
Device: Samsung S 5 (Android 4.4)
Builds: Firefox for Android 39.0a2 (2015-04-08) and Firefox for Android 40.0a1 (2015-04-07)
status-firefox39: fixed → verified
status-firefox40: fixed → verified
The bug is fixed on Beta 38.0b3 also.
Verifying.
Status: RESOLVED → VERIFIED
status-firefox38: fixed → verified
(Assignee)

Comment 12

4 years ago
Comment on attachment 8587968 [details]
MozReview Request: bz://1150872/margaret
Attachment #8587968 - Attachment is obsolete: true
Attachment #8619963 - Flags: review+

Updated

8 months ago
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.