1150880 - Add support for l10n repacks to Treeherder

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Data Ingestion, defect, P1)

Description

[Ryan VanderMeulen [:RyanVM]]

These jobs were recently added and are showing up as unknown on Treeherder.

Firefox mozilla-central linux nightly l10n x/3
Firefox mozilla-central linux64 nightly l10n x/3
Firefox mozilla-central macosx64 nightly l10n x/3

The linux jobs show up as regular nightlies. The OSX ones are completely unknown. I'm not even sure how I'm going to hide these at the moment.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Firefox mozilla-central win32 nightly l10n x/3

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Firefox mozilla-central win64 nightly l10n x/3

Comment 3

[Ryan VanderMeulen [:RyanVM]]

I was hoping to get a patch up for this, but I'm out of time for the day. I'd envision these being handled similar to how we deal with Android, i.e. L10N(N1 N2 N3).

Cam, given that this is aggravated by bug 1087349, can we please prioritize fixing and getting this into production today?

Comment 4

[Cameron Dawson [:camd]]

working on a patch for this now.

Comment 5

[Cameron Dawson [:camd]]

Attachment: l10n repack support PR

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8588181 [details] [review]
l10n repack support PR

Thanks for jumping on this :)

Comment 7

[Cameron Dawson [:camd]]

Ryan- If you'd like me to try to push this out today, perhaps you could do the review to see if it looks right to you?  Ed and Mauro are both out today.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8588181 [details] [review]
l10n repack support PR

Given the passing tests and  in the interests of getting this into production ASAP, r=me with the win64 change to buildbot.py moved up to the pre-existing win64 block as discussed on IRC. That said, I'd still like Mauro/Ed to take a retroactive look at this since my regex-fu isn't exactly superb :)

Comment 9

[Cameron Dawson [:camd]]

Ed: I hope it's ok to transfer the review of this to you, since you often review stuff like this.

Comment 10

[Ed Morley [:emorley]]

Comment on attachment 8588181 [details] [review]
l10n repack support PR

IMO we should insist they fix the buildernames; some time ago I spent a while getting rid of the old style "X/Y" numbering and simplifying all the regex as a result; and they've now regressed this. 

Things like:
NUMBER_RE = re.compile(r"((?<=-)\d+|\d+(?=/\d+))(?:/\d+)?$")

...just make me want to stab my eyes out :-(

I've added a couple of tweaks to the PR; and will file a bug to get them to fix the buildernames, and then we can remove the support for the alternative format.

Comment 11

[Ed Morley [:emorley]]

To be clear: I didn't mean this was your fault Cameron, you weren't too know the history here, it's just been a frustrating few years of back and forth with tbpl and buildbot-config changes that are often inconsistent and we're only told about retrospectively. One day... :-)

Comment 12

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder-service

https://github.com/mozilla/treeherder-service/commit/d7abe14635eb4f00584d4e99a78f03b8c88f4cea
Bug 1150880 - add regex handling for l10n repacks

Comment 13

[Cameron Dawson [:camd]]

No worries at all.  Sounds good.  Task Cluster to the rescue!  :)

Comment 14

[Ed Morley [:emorley]]

(In reply to Cameron Dawson [:camd] from comment #13)
> Task Cluster to the rescue!  :)

Indeed! Thanks for taking this bug whilst I was away :-)