1150894 - Reproducible crash in [@ ShConstructCompiler ] from DYLD_FORCE_FLAT_NAMESPACE and/or DYLD_INSERT_LIBRARIES

Status: RESOLVED INVALID

(Core :: Graphics, defect)

Description

[Gregory Seidman]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:37.0) Gecko/20100101 Firefox/37.0
Build ID: 20150326190726

Steps to reproduce:

From a shell on OS X:
1. export DYLD_INSERT_LIBRARIES=/opt/X11/lib/libXaw3d.dylib
2. export DYLD_FORCE_FLAT_NAMESPACE=1
3. /Applications/Firefox.app/Contents/MacOS/firefox-bin -no-remote -ProfileManager


Actual results:

Crash: https://crash-stats.mozilla.com/report/index/bp-2796a271-2059-4c5d-96a0-836362150403


Expected results:

Launched Firefox, opening the profile manager.

Comment 1

[Gregory Seidman]

There is probably no reason to allow these environment variables at all. I recommend that at the earliest possible moment in the execution (i.e. right at the beginning of main() on any *nix platform) checking for the presence of these variables and LD_PRELOAD as well and, if found, remove them from the environment and execv() again.

Comment 2

[Markus Stange [:mstange]]

Who sets these environment variables? How did you run into this crash in the first place?

Comment 3

[Gregory Seidman]

(In reply to Markus Stange [:mstange] from comment #2)
> Who sets these environment variables? How did you run into this crash in the
> first place?

I'm not going to claim it's a great idea, but I've been doing it for about two decades. The Xaw (Athena Widgets) library is what xterm, among other X11 apps, uses. The Xaw3D library is a drop-in replacement that gives a different look (mainly to scrollbars and menus) and some slightly different behavior (left-clicking on the thumb on a scrollbar, for example). Since I prefer the Xaw3D look and behavior, I preload libXaw3d (on both OS X and Linux) using environment variables.

Comment 4

[u279076]

I'm closing this as invalid. The last time this crash was reported was 4 months ago with Firefox 44. It might be valid if this crash were still reproducible but it seems like too much of an edge case to support. That said I'm sure we'd accept a patch if someone wanted to write one - feel free to reopen if you want to work on this.