11509 - [code] nsMsgAccountManager::prefService() needs to be more robust

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect, P3)

Description

[John Bandhauer]

[choosing a buzilla 'component' at random, 'assignedto' based on cvsblame]

nsMsgAccountManager::prefService() is part of what is called in just creating
the components with progids that begin with:

component://netscape/messengercompose/compose
component://netscape/messenger
component://netscape/rdf/datasource?name=msgaccountmanager
component://netscape/rdf/datasource?name=mailnewsfolders
component://netscape/rdf/datasource?name=msgnotifications
component://netscape/rdf/datasource?name=mailnewsmessages

(there may be others?)

It has the wonderful assert:

NS_ASSERTION(NS_SUCCEEDED(rv),
             "prefs service not available. I will crash soon!");

It delivers what it promises.

These components register themselves with the component manager and can be
instantiated from JS - with or without a prefs service handy.

Creating a component, doing a few QI calls and then Releasing it should never
crash the process. But here is does.

Please make this more robust.

Comment 1

[Alec Flett]

erg. I guess I was kind of expecting that prefs would be available, but I see
your point. I guess I better start using NS_WITH_SERVICE to load this service on
demand instead.

Comment 2

[scottputterman]

moving to M10

Comment 3

[Alec Flett]

I've made the following interface implementations much more robust with respect
to prefs:
nsMsgAccount
nsMsgAccountManager
nsMsgIdentity

I still have nsMsgIncomingServer to go.
(all to be checked in for M10)

Comment 4

[Alec Flett]

ok, done. I even tried your cool enum script, and it works beautifully.

Comment 5

[ppandit]

Changing QA contact to ppandit

Comment 6

[ppandit]

The usual way of making it more robust is the following:

if (m_prefs) return NS_OK;
return nsServiceManager::GetService(kPrefServiceCID,
                                      nsCOMTypeInfo<nsIPref>::GetIID(),
                                      (nsISupports**)&m_prefs,
                                      this);

Based on looking at the code, VERIFIED