1150941 - Make the tests from bug 1148855 pass (at least those that are disabled due to layer activity timeout or event regions)

Status: NEW

(Core :: Layout, defect)

Description

[Markus Stange [:mstange]]

Bug 1148855 added a few tests that fail with event regions, and of those a few passed intermittently (so I disabled them completely). We should fix things so that they always pass.

Comment 1

[Markus Stange [:mstange]]

This is the changeset that disabled them: https://hg.mozilla.org/integration/mozilla-inbound/rev/c61a8d4b2963

Comment 2

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/c61a8d4b2963

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Once APZ is on by default everywhere tests that are skip-if(asyncPanZoom) will be no-ops, so we should either get those tests re-enabled or get rid of them. Marking this as blocking bug 1178298 so that it shows up in the APZ bug tree.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Attachment: Re-enable pull-background-5

Based on the try push at https://treeherder.mozilla.org/#/jobs?repo=try&revision=62583d014b6f I think this one test at least is safe to re-enable.

Comment 5

[Markus Stange [:mstange]]

Comment on attachment 8637659 [details] [diff] [review]
Re-enable pull-background-5

Review of attachment 8637659 [details] [diff] [review]:
-----------------------------------------------------------------

Looks like I never debugged why the test failed after I had tried to re-enable it in bug 1148515, so if it's passing now, that's great.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0eb5798fcae6

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0eb5798fcae6

Comment 8

[Botond Ballo [:botond]]

Markus, should this bug be closed?

Comment 9

[Markus Stange [:mstange]]

The important tests have been enabled, but the "animated-position" ones are still disabled, for layer activity timeout reasons. Let's leave this bug open for those. I'll remove this bug from the all-aboard-apz blocking list.

We'll probably need bug 1151346 if we want to have reliable tests with animated left/top/right/bottom properties.

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:svoisen, maybe it's time to close this bug?

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:svoisen, maybe it's time to close this bug?

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:svoisen, maybe it's time to close this bug?

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:svoisen, maybe it's time to close this bug?