Make the tests from bug 1148855 pass (at least those that are disabled due to layer activity timeout or event regions)

NEW
Unassigned

Status

()

Core
Layout
3 years ago
2 years ago

People

(Reporter: mstange, Unassigned)

Tracking

({leave-open})

Trunk
x86
Mac OS X
leave-open
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox40 affected)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
Bug 1148855 added a few tests that fail with event regions, and of those a few passed intermittently (so I disabled them completely). We should fix things so that they always pass.
(Reporter)

Comment 1

3 years ago
This is the changeset that disabled them: https://hg.mozilla.org/integration/mozilla-inbound/rev/c61a8d4b2963
Keywords: leave-open
Blocks: 1094369
Once APZ is on by default everywhere tests that are skip-if(asyncPanZoom) will be no-ops, so we should either get those tests re-enabled or get rid of them. Marking this as blocking bug 1178298 so that it shows up in the APZ bug tree.
Blocks: 1178298
Created attachment 8637659 [details] [diff] [review]
Re-enable pull-background-5

Based on the try push at https://treeherder.mozilla.org/#/jobs?repo=try&revision=62583d014b6f I think this one test at least is safe to re-enable.
Attachment #8637659 - Flags: review?(mstange)
(Reporter)

Comment 5

3 years ago
Comment on attachment 8637659 [details] [diff] [review]
Re-enable pull-background-5

Review of attachment 8637659 [details] [diff] [review]:
-----------------------------------------------------------------

Looks like I never debugged why the test failed after I had tried to re-enable it in bug 1148515, so if it's passing now, that's great.
Attachment #8637659 - Flags: review?(mstange) → review+
Markus, should this bug be closed?
Flags: needinfo?(mstange)
(Reporter)

Comment 9

2 years ago
The important tests have been enabled, but the "animated-position" ones are still disabled, for layer activity timeout reasons. Let's leave this bug open for those. I'll remove this bug from the all-aboard-apz blocking list.

We'll probably need bug 1151346 if we want to have reliable tests with animated left/top/right/bottom properties.
No longer blocks: 1178298
Flags: needinfo?(mstange)
You need to log in before you can comment on or make changes to this bug.