Open
Bug 1150941
Opened 10 years ago
Updated 9 months ago
Make the tests from bug 1148855 pass (at least those that are disabled due to layer activity timeout or event regions)
Categories
(Core :: Layout, defect)
Tracking
()
NEW
Tracking | Status | |
---|---|---|
firefox40 | --- | affected |
People
(Reporter: mstange, Unassigned)
References
Details
Attachments
(1 file)
1.64 KB,
patch
|
mstange
:
review+
kats
:
checkin+
|
Details | Diff | Splinter Review |
Bug 1148855 added a few tests that fail with event regions, and of those a few passed intermittently (so I disabled them completely). We should fix things so that they always pass.
Reporter | ||
Comment 1•10 years ago
|
||
This is the changeset that disabled them: https://hg.mozilla.org/integration/mozilla-inbound/rev/c61a8d4b2963
Keywords: leave-open
Comment 2•10 years ago
|
||
Comment 3•10 years ago
|
||
Once APZ is on by default everywhere tests that are skip-if(asyncPanZoom) will be no-ops, so we should either get those tests re-enabled or get rid of them. Marking this as blocking bug 1178298 so that it shows up in the APZ bug tree.
Blocks: all-aboard-apz
Comment 4•10 years ago
|
||
Based on the try push at https://treeherder.mozilla.org/#/jobs?repo=try&revision=62583d014b6f I think this one test at least is safe to re-enable.
Attachment #8637659 -
Flags: review?(mstange)
Reporter | ||
Comment 5•10 years ago
|
||
Comment on attachment 8637659 [details] [diff] [review]
Re-enable pull-background-5
Review of attachment 8637659 [details] [diff] [review]:
-----------------------------------------------------------------
Looks like I never debugged why the test failed after I had tried to re-enable it in bug 1148515, so if it's passing now, that's great.
Attachment #8637659 -
Flags: review?(mstange) → review+
Updated•10 years ago
|
Attachment #8637659 -
Flags: checkin+
Comment 7•10 years ago
|
||
Reporter | ||
Comment 9•9 years ago
|
||
The important tests have been enabled, but the "animated-position" ones are still disabled, for layer activity timeout reasons. Let's leave this bug open for those. I'll remove this bug from the all-aboard-apz blocking list.
We'll probably need bug 1151346 if we want to have reliable tests with animated left/top/right/bottom properties.
No longer blocks: all-aboard-apz
Flags: needinfo?(mstange)
Comment 10•7 years ago
|
||
The leave-open keyword is there and there is no activity for 6 months.
:svoisen, maybe it's time to close this bug?
Flags: needinfo?(svoisen)
Comment 11•6 years ago
|
||
The leave-open keyword is there and there is no activity for 6 months.
:svoisen, maybe it's time to close this bug?
Flags: needinfo?(svoisen)
Comment 12•6 years ago
|
||
The leave-open keyword is there and there is no activity for 6 months.
:svoisen, maybe it's time to close this bug?
Flags: needinfo?(svoisen)
Updated•5 years ago
|
Flags: needinfo?(svoisen)
Comment 13•5 years ago
|
||
The leave-open keyword is there and there is no activity for 6 months.
:svoisen, maybe it's time to close this bug?
Flags: needinfo?(svoisen)
Updated•5 years ago
|
Flags: needinfo?(svoisen)
Keywords: leave-open
Updated•3 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•