115095 - dates are not handled in a portable manner

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Julien Pierre]

The code in mozilla/mailnews/db/msgdb/public/nsDBFolderInfo.h uses time_t for
storing dates. This has the problem of 32-bit rollover in the year 2038.
In addition, the code in mozilla/mailnews/db/msgdb/nsDBFolderInfo.cpp uses
PRUint32 in many places to manipulate the folder date. This is incorrect also
and will suffer from the rollover problem.

There is also a portability issue, as reported in bug 114501.
The code should use PRTime and rely on NSPR functions to get/compare the time.
PRTime has enough storage/precision not to suffer from rollover or portability
problems. It should be a goal in all of Mozilla to standardize on using PRTime.

Comment 1

[David :Bienvenu]

future...

Comment 2

[David :Bienvenu]

when the fix for 114501 is checked in, there won't be any use of time_t, and the
fix for that addresses the known portability issue. As we get closer to 2038, we
can address the roll-over issue. It's not worth revving everyone's database and
introducing backwards incompatibility at this point.

Comment 3

[Arun Prasannan (polar)]

This bug is being marked EXPIRED as it has seen no activity in a very long time.

If you think that the issue reported might still be relevant, please test with a recent release of SeaMonkey and if the problem persists feel free to re-open the report. Thank you.

http://www.seamonkey-project.org/

Comment 4

[Mark Banner (:standard8)]

Bulk reopening incorrectly expired bugs - no activity does not constitute no bug - these need proper checking.

Comment 5

[Philip Chee]

Fixed by the fix in Bug 114501. Please file another bug for Y2K38 issues.