1151061 - Prefetch download is not canceled, when source tab is closed

Status: RESOLVED WORKSFORME

(Firefox :: General, defect)

Description

[Zaxx]

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:36.0) Gecko/20100101 Firefox/36.0
Build ID: 20150320202338

Steps to reproduce:

1.) Start Firefox and open at least two tabs
2.) Click at download link of some big file (from data sharing server for example)
3.) Dialog with choice "OPEN or DOWNLOAD" will be shown
(at this time download begins - prefetching to temporary directory)




Actual results:

1.) If user clicks on button "OK" of this dialog, download succesfully continues and file is downloaded to standard target directory -> thats OK
2.) If user clicks on button "CANCEL" of the dialog, download is correctly interrupted and temporary file is deleted -> thats OK too
but...
If user closes the tab from which the download was initiated and clicks on button "OK" at dialog, dialog disappears, at download manager is not any active downloading shown, but downloading of file CONTINUES at the background until the entire file were downloaded. File (with random name) stays in temporary directory (on XP at "C:\Documents And Settings\[Account name]\Local Settings\Temp") even after the Firefox ends. This can bee a problem for many users I think (slowing down the Internet connection, wasting disk space)...


Expected results:

If user closes the tab, from which the download was initiated and next clicks at OK button, download of the file should maybe continue (classically in download manager).

Comment 1

[kenkon]

[bugday-20150406]

Firefox 37.0.1 : same result as reporter, I can reproduce it.

Beta 38.0 (20150330154247) : the prefetching continues after the tab is closed by user, the dialog disappears after I click "OK" but the difference is that the prefetching stops immediately and the part file is deleted automatically from Temp folder.

Nightly 40.0a1 (20150406030204) : same as Beta 38.

All of the above happens when "Ask me where to save files" is selected. Otherwise the file is saved to Downloads folder even if the tab was closed by user before clicking OK in the dialog.

IMHO two possible behaviors would be acceptable (after user closes tab):
 1. the user clicks OK, the "Save As..." dialog is shown and the download continues normally OR
 2. the "Open..." dialog is closed automatically by Firefox as soon as the user closes the tab and the download/prefetching is automatically cancelled and the part file deleted.

Comment 2

[ovidiu boca[:Ovidiu]]

I tested this on Firefox Nightly 45.0a1 on Win XP and I can't reproduce the problem. Please retest this with Firefox Nightly 45.0a1, you can download it from here: https://nightly.mozilla.org/ 
If you can reproduce it please add the steps.

Comment 3

[ovidiu boca[:Ovidiu]]

Hi,
Marking this as Resolved: Incomplete due to the lack of response from the reporter.
Reporter, please feel free to reopen it if you are still having this issue on the latest Firefox version.  Thank you for your time.

Comment 4

[Zaxx]

Hi,
 sorry for my delayed response (I'm really busy). I test it on latest version of the Firefox (43.0.1) and problem is probably solved correctly -> if tab, from which the download dialog was called and then is clicked "OK" button on download dialog, correct "Save file as" dialog is shown. When "Save as" dialog is shown, download is paused (temporary file still exist, but downloading don't continue). If "Save file as" dialog is canceled, temporary file is deleted, when is correct file name selected and button "OK" were clicked, download correctly continues until the end of downloaded file. This is correct behavior, in my opinion, so... I thing this bug was removed...

PS: Sorry for my bad english... :-(

Comment 5

[YF (Yang)]

per https://developer.mozilla.org/en-US/docs/What_to_do_and_what_not_to_do_in_Bugzilla#Resolving_bugs_as_WORKSFORME.

Comment 6

[Zaxx]

OK. Sorry YF (Yang), I select bad status...