If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Swatch/thumbnail of lightweight theme missing in Customize Mode

NEW
Unassigned

Status

()

Firefox
Toolbars and Customization
3 years ago
3 years ago

People

(Reporter: liuche, Unassigned)

Tracking

Trunk
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(firefox40 affected)

Details

Attachments

(3 attachments)

(Reporter)

Description

3 years ago
Created attachment 8588219 [details]
Screenshot: Off-center "Themes" label
(In reply to Chenxia Liu [:liuche] from comment #0)
> Created attachment 8588219 [details]
> Screenshot: Off-center "Themes" label

What build were you running and did you have a lightweight theme enabled? The blank space you're seeing is supposed to have a thumbnail of the selected lightweight theme (or a placeholder graphic if one isn't selected).

This just got tweaked recently in bug 1139949, so this may be a regression from that.
Summary: Center text for "Themes" button → Swatch/thumbnail of lightweight theme missing in Customize Mode
Flags: needinfo?(liuche)
(Reporter)

Comment 2

3 years ago
I did have a lightweight theme selected, but it looks like it's broken and doesn't have a thumbnail.
Flags: needinfo?(liuche)
Can you share which lightweight theme you had selected?
Flags: needinfo?(liuche)
(Reporter)

Comment 4

3 years ago
Created attachment 8588681 [details]
Screenshot: Old theme (not working on mouseover)

Hah, sorry, I should have done that earlier.

It looks like an old version of Firefox B ( https://addons.mozilla.org/en-US/firefox/addon/firefox-b/ ), but I was also able to install the new version. Attached a screenshot where I have both installed, and one of them isn't working.
Flags: needinfo?(liuche)
(Reporter)

Comment 5

3 years ago
Created attachment 8588683 [details]
Screenshot: New theme (working)
(Reporter)

Updated

3 years ago
Attachment #8588681 - Attachment description: Screenshot: Old and new theme → Screenshot: Old theme (not working on mouseover)
Flags: needinfo?(jaws)
Hmm, I looked on AMO but I don't see a way to install an older version of the theme. Can you inspect the popup and either take a screenshot of the fully-expanded DOM node for that item or copy/paste the outerHTML here?
Flags: needinfo?(jaws) → needinfo?(liuche)

Comment 7

3 years ago
Jorge, is there some way to find an older version of a theme on AMO?
Flags: needinfo?(jorge)
No, I think the files are just replaced when a new version is uploaded. Wil might know for sure.
Flags: needinfo?(jorge)
Liuche sent me this snippet showing what the markup is for this theme:

>     <toolbarbutton class="customization-lwtheme-menu-theme" label="Firefox B" image="https://addons.cdn.mozilla.net/_files/15114/preview_small.jpg?1229632195" tabindex="0" aria-checked="true" role="menuitemradio" active="true">
>         <xul:image class="toolbarbutton-icon" xbl:inherits="validate,src=image,label,consumeanchor" label="Firefox B" src="https://addons.cdn.mozilla.net/_files/15114/preview_small.jpg?1229632195"></xul:image>
>         <xul:label class="toolbarbutton-text" crop="right" flex="1" xbl:inherits="value=label,accesskey,crop,wrap" value="Firefox B"></xul:label>
>         <xul:label class="toolbarbutton-multiline-text" flex="1" xbl:inherits="xbl:text=label,accesskey,wrap" text="Firefox B">
>             Firefox B
>             <html:span anonid="accessKeyParens"></html:span>
>         </xul:label>
>     </toolbarbutton> 

Note that the URL for the icon returns a 404. We could supply a fallback background but in this case, the theme is busted regardless. So I'm not sure what benefit we are getting besides cosmetically covering up some other bug.
Flags: needinfo?(liuche)
You need to log in before you can comment on or make changes to this bug.