1151134 - Improve external encoder verification

Status: NEW

(Core :: WebRTC: Audio/Video, defect, P5)

Description

[Nils Ohlmeier [:drno]]

Bug 1148572 fixed the re-use of an external encoder with existing code.

We should replace that quick fix, with cleaner code which allows to verify if an external encoder is set already. If it exists re-use it only if it has the matching config and otherwise properly free the old and create a new encoder.

Comment 1

[Nils Ohlmeier [:drno]]

Attachment: bug_1151134_external_codec.patch

This should a better solution then relying on a plugin ID to not zero.

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8588238 [details] [diff] [review]
bug_1151134_external_codec.patch

Review of attachment 8588238 [details] [diff] [review]:
-----------------------------------------------------------------

I'd like to see if we can make this at least fairly easily extendable to other external codecs.  Perhaps they'd still need code here, but it could be more combined and clearer.  However, we could do that when we add another external encoder type.  (Hmm, what about the VP8 work Intel did?)

Comment 3

[Bulk Bug Changes for mreavy's org]

Mass change P4->P5 to align with new Mozilla triage process.