Closed Bug 1151136 Opened 9 years ago Closed 9 years ago

valgrind "Syscall param sendmsg(msg.msg_iov[0]) points to uninitialised byte(s)" due to uninitialized aSeqno from TabParent::RecvNotifyIMEFocus

Categories

(Core :: Widget, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: dbaron, Assigned: dbaron)

Details

(Keywords: valgrind)

Attachments

(1 file)

While running the glterrain talos test file
https://hg.mozilla.org/build/talos/raw-file/b826a38ef31f/talos/page_load_test/webgl/benchmarks/terrain/perftest.html
under valgrind, I saw this warning once per run:

==17902== Thread 4 Gecko_IOThread:
==17902== Syscall param sendmsg(msg.msg_iov[0]) points to uninitialised byte(s)
==17902==    at 0x4E469BD: ??? (/build/buildd/eglibc-2.19/nptl/../sysdeps/unix/syscall-template.S:81)
==17902==    by 0x820E03A: IPC::Channel::ChannelImpl::ProcessOutgoingMessages() (/home/dbaron/builds/ssd/mozilla-central/mozilla/ipc/chromium/src/chrome/common/ipc_channel_posix.cc:719)
==17902==    by 0x81FC3EB: MessageLoop::RunTask(Task*) (/home/dbaron/builds/ssd/mozilla-central/mozilla/ipc/chromium/src/base/message_loop.cc:375)
==17902==    by 0x8201161: MessageLoop::DeferOrRunPendingTask(MessageLoop::PendingTask const&) (/home/dbaron/builds/ssd/mozilla-central/mozilla/ipc/chromium/src/base/message_loop.cc:383)
==17902==    by 0x8201290: MessageLoop::DoWork() (/home/dbaron/builds/ssd/mozilla-central/mozilla/ipc/chromium/src/base/message_loop.cc:470)
==17902==    by 0x81FB468: base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) (/home/dbaron/builds/ssd/mozilla-central/mozilla/ipc/chromium/src/base/message_pump_libevent.cc:328)
==17902==    by 0x81FD122: MessageLoop::RunInternal() (/home/dbaron/builds/ssd/mozilla-central/mozilla/ipc/chromium/src/base/message_loop.cc:247)
==17902==    by 0x81FD153: MessageLoop::Run() (/home/dbaron/builds/ssd/mozilla-central/mozilla/ipc/chromium/src/base/message_loop.cc:240)
==17902==    by 0x8209651: base::Thread::ThreadMain() (/home/dbaron/builds/ssd/mozilla-central/mozilla/ipc/chromium/src/base/thread.cc:170)
==17902==    by 0x8203A87: ThreadFunc(void*) (/home/dbaron/builds/ssd/mozilla-central/mozilla/ipc/chromium/src/base/platform_thread_posix.cc:39)
==17902==    by 0x4E3F181: start_thread (/build/buildd/eglibc-2.19/nptl/pthread_create.c:312)
==17902==    by 0x595D47C: clone (/build/buildd/eglibc-2.19/misc/../sysdeps/unix/sysv/linux/x86_64/clone.S:111)
==17902==  Address 0x3e438184 is 36 bytes inside a block of size 64 alloc'd
==17902==    at 0x4C2AB80: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==17902==    by 0x4C2CF1F: realloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==17902==    by 0x8204BD5: Pickle::Resize(unsigned int) (/home/dbaron/builds/ssd/mozilla-central/mozilla/ipc/chromium/src/base/pickle.cc:645)
==17902==    by 0x8204CB1: Pickle::Pickle(int) (/home/dbaron/builds/ssd/mozilla-central/mozilla/ipc/chromium/src/base/pickle.cc:118)
==17902==    by 0x82165A6: IPC::Message::Message(int, unsigned int, IPC::Message::PriorityValue, IPC::Message::MessageCompression, char const*) (/home/dbaron/builds/ssd/mozilla-central/mozilla/ipc/chromium/src/chrome/common/ipc_message.cc:46)
==17902==    by 0x840A65B: mozilla::dom::PBrowserParent::OnMessageReceived(IPC::Message const&, IPC::Message*&) (/home/dbaron/builds/ssd/mozilla-central/obj/firefox-debugopt/ipc/ipdl/_ipdlheaders/mozilla/dom/PBrowser.h:1173)
==17902==    by 0x8229665: mozilla::ipc::MessageChannel::DispatchSyncMessage(IPC::Message const&) (/home/dbaron/builds/ssd/mozilla-central/mozilla/ipc/glue/MessageChannel.cpp:1203)
==17902==    by 0x822A18B: mozilla::ipc::MessageChannel::DispatchMessage(IPC::Message const&) (/home/dbaron/builds/ssd/mozilla-central/mozilla/ipc/glue/MessageChannel.cpp:1160)
==17902==    by 0x822D040: mozilla::ipc::MessageChannel::OnMaybeDequeueOne() (/home/dbaron/builds/ssd/mozilla-central/mozilla/ipc/glue/MessageChannel.cpp:1148)
==17902==    by 0x81FC3EB: MessageLoop::RunTask(Task*) (/home/dbaron/builds/ssd/mozilla-central/mozilla/ipc/chromium/src/base/message_loop.cc:375)
==17902==    by 0x8201161: MessageLoop::DeferOrRunPendingTask(MessageLoop::PendingTask const&) (/home/dbaron/builds/ssd/mozilla-central/mozilla/ipc/chromium/src/base/message_loop.cc:383)
==17902==    by 0x8201290: MessageLoop::DoWork() (/home/dbaron/builds/ssd/mozilla-central/mozilla/ipc/chromium/src/base/message_loop.cc:470)
==17902==    by 0x8221196: mozilla::ipc::DoWorkRunnable::Run() (/home/dbaron/builds/ssd/mozilla-central/mozilla/ipc/glue/MessagePump.cpp:233)
==17902==    by 0x7F6F1F2: nsThread::ProcessNextEvent(bool, bool*) (/home/dbaron/builds/ssd/mozilla-central/mozilla/xpcom/threads/nsThread.cpp:841)
==17902==    by 0x7F912D7: NS_ProcessNextEvent(nsIThread*, bool) (/home/dbaron/builds/ssd/mozilla-central/mozilla/xpcom/glue/nsThreadUtils.cpp:265)
==17902==    by 0x822571A: mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) (/home/dbaron/builds/ssd/mozilla-central/mozilla/ipc/glue/MessagePump.cpp:99)
==17902==    by 0x81FD122: MessageLoop::RunInternal() (/home/dbaron/builds/ssd/mozilla-central/mozilla/ipc/chromium/src/base/message_loop.cc:247)
==17902==    by 0x81FD153: MessageLoop::Run() (/home/dbaron/builds/ssd/mozilla-central/mozilla/ipc/chromium/src/base/message_loop.cc:240)
==17902==    by 0x96D9E62: nsBaseAppShell::Run() (/home/dbaron/builds/ssd/mozilla-central/mozilla/widget/nsBaseAppShell.cpp:164)
==17902==    by 0x9E0CD52: nsAppStartup::Run() (/home/dbaron/builds/ssd/mozilla-central/mozilla/toolkit/components/startup/nsAppStartup.cpp:281)
==17902==    by 0x9E565DA: XREMain::XRE_mainRun() (/home/dbaron/builds/ssd/mozilla-central/mozilla/toolkit/xre/nsAppRunner.cpp:4172)
==17902==    by 0x9E5695A: XREMain::XRE_main(int, char**, nsXREAppData const*) (/home/dbaron/builds/ssd/mozilla-central/mozilla/toolkit/xre/nsAppRunner.cpp:4248)
==17902==    by 0x9E56BA4: XRE_main (/home/dbaron/builds/ssd/mozilla-central/mozilla/toolkit/xre/nsAppRunner.cpp:4468)
==17902==    by 0x403BEB: do_main(int, char**, nsIFile*) (/home/dbaron/builds/ssd/mozilla-central/mozilla/browser/app/nsBrowserApp.cpp:294)
==17902==    by 0x4034CA: main (/home/dbaron/builds/ssd/mozilla-central/mozilla/browser/app/nsBrowserApp.cpp:667)
==17902==  Uninitialised value was created by a stack allocation
==17902==    at 0x840962D: mozilla::dom::PBrowserParent::OnMessageReceived(IPC::Message const&, IPC::Message*&) (/home/dbaron/builds/ssd/mozilla-central/obj/firefox-debugopt/ipc/ipdl/PBrowserParent.cpp:2584)
Assignee: nobody → dbaron
The above patch makes the valgrind warning stop happening (at least based on one test run).
Attachment #8588231 - Flags: review?(masayuki) → review+
https://hg.mozilla.org/mozilla-central/rev/efcc95ba16c3
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: