Closed Bug 1151147 Opened 9 years ago Closed 3 years ago

MenuItemActionView does not inherit from Widget.MenuItemActionView

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: mcomella, Unassigned)

References

Details

Because we call [1]:

  super(context, attrs);

which drops the style, even though we pass it in from another constructor [2]:

  this(context, attrs, R.attr.menuItemActionViewStyle);

Luckily, Widget.MenuItemActionView doesn't have anything useful in it.

[1]: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/menu/MenuItemActionView.java?rev=d35c3eb5eed8#41
[2]: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/menu/MenuItemActionView.java?rev=d35c3eb5eed8#36
Note that we can't directly call:

  super(context, attrs, R.attr.menuItemActionViewStyle);

because it's not available in the GB API.
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INCOMPLETE
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.