Closed Bug 1151156 Opened 5 years ago Closed 2 years ago

Remove stupid fake resumption packet generation when Gecko 40 is on b2g-stable

Categories

(DevTools :: Debugger, defect)

x86_64
Linux
defect
Not set

Tracking

(firefox59 fixed)

RESOLVED FIXED
Firefox 59
Tracking Status
firefox59 --- fixed

People

(Reporter: shu, Assigned: jdescottes)

References

Details

Attachments

(1 file)

See bug 1151154
Removing traits in complicated by the b2g simulators and devices which live on indefinitely in the field.

Eventually we may need to end support for some, but so far we haven't done such a thing before.
(In reply to J. Ryan Stinnett [:jryans] from comment #1)
> Removing traits in complicated by the b2g simulators and devices which live
> on indefinitely in the field.
> 
> Eventually we may need to end support for some, but so far we haven't done
> such a thing before.

The policy I've always heard (and used) was that we support the latest stable b2g, and not older than that.
Depends on: 1151154
(In reply to Nick Fitzgerald [:fitzgen] from comment #2)
> (In reply to J. Ryan Stinnett [:jryans] from comment #1)
> > Removing traits in complicated by the b2g simulators and devices which live
> > on indefinitely in the field.
> > 
> > Eventually we may need to end support for some, but so far we haven't done
> > such a thing before.
> 
> The policy I've always heard (and used) was that we support the latest
> stable b2g, and not older than that.

How do you define b2g stable precisely?

Our compatibility page still states we support back to FxOS 1.3.  Is this different from your understanding?
(In reply to J. Ryan Stinnett [:jryans] from comment #3)
> (In reply to Nick Fitzgerald [:fitzgen] from comment #2)
> > (In reply to J. Ryan Stinnett [:jryans] from comment #1)
> > > Removing traits in complicated by the b2g simulators and devices which live
> > > on indefinitely in the field.
> > > 
> > > Eventually we may need to end support for some, but so far we haven't done
> > > such a thing before.
> > 
> > The policy I've always heard (and used) was that we support the latest
> > stable b2g, and not older than that.
> 
> How do you define b2g stable precisely?
> 
> Our compatibility page still states we support back to FxOS 1.3.  Is this
> different from your understanding?

My understanding was that they branch off every ~8 Firefox releases or some number, and so we support the most recent branch.
Apart from b2g 1.0 - 1.2, which was missing a whole bunch of basic stuff, I don't think we have ever explicitly declared another version as unsupported. We should do so at some point, but it's not clear when it would be a good time to do it and we would need some device usage numbers to guide us.
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Comment on attachment 8936721 [details]
Bug 1151156 - remove unused b2g code in debugger-client onPacket;

https://reviewboard.mozilla.org/r/207456/#review213752

Thanks for looking into this!

Since we already have WebIDE ensuring old clients can't connect to newer servers, it seems safe to remove both parts together.
Attachment #8936721 - Flags: review?(jryans) → review+
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4186b4a812fc
remove unused b2g code in debugger-client onPacket;r=jryans
https://hg.mozilla.org/mozilla-central/rev/4186b4a812fc
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.