Closed Bug 1151166 Opened 9 years ago Closed 9 years ago

Fix Coverity warnings in image/decoders/nsPNGDecoder.cpp

Categories

(Core :: Graphics: ImageLib, defect)

Product:
Core
Component:
Graphics: ImageLib
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla41
Tracking Flags:
Tracking Status
firefox40 --- affected
firefox41 --- fixed

People

(Reporter: glennrp+bmo, Assigned: glennrp+bmo)

Details

Attachments

(1 file, 1 obsolete file)

v01-1151166-quiet-nsPNGDecoder.cpp-warnings
1.66 KB, patch
jrmuizel
: review+
Details | Diff | Splinter Review 
Coverity currently issues two warnings about image/decoders/nsPNGDecoder.cpp:
CID 748746 - channels might be zero
CID 1286520 - format is not intialized

Neither of these appears to be harmful but they can be easily suppressed.
Comment on attachment 8588261 [details] [diff] [review]
v00-1151166-quiet-nsPNGDecoder.cpp-warnings

Please submit to try.
Flags: needinfo?(ryanvm)
Attachment #8588261 - Flags: review?(jmuizelaar)
Rebased nsPNGDecoder.cpp
Attachment #8588261 - Attachment is obsolete: true
Attachment #8588261 - Flags: review?(jmuizelaar)
Attachment #8610534 - Flags: review?(jmuizelaar)
Attachment #8610534 - Flags: review?(jmuizelaar) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/dcf63eddd771
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: