Closed
Bug 1151184
Opened 9 years ago
Closed 9 years ago
test_load_modules and bagheera* tests run for builds without MOZ_SERVICES_HEALTHREPORT after bug 1148990
Categories
(Cloud Services :: Firefox: Common, defect)
Cloud Services
Firefox: Common
Tracking
(firefox40 fixed)
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: aryx, Assigned: aryx)
References
Details
Attachments
(1 file)
2.47 KB,
patch
|
rnewman
:
review+
|
Details | Diff | Splinter Review |
https://hg.mozilla.org/mozilla-central/rev/042755670a6d from bug 1148990 lets the application only ship with bagheeraclient.js and bagheeraserver.js if MOZ_SERVICES_HEALTHREPORT is 1/true but always tries to import them and run theirs tests if the OS isn't Android. This fails if one build without MOZ_SERVICES_HEALTHREPORT (like Thunderbird at the moment). So this patch adds the health report condition to the tests.
Attachment #8588281 -
Flags: review?(rnewman)
Comment 1•9 years ago
|
||
Comment on attachment 8588281 [details] [diff] [review] patch, v1 Review of attachment 8588281 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for the catch!
Attachment #8588281 -
Flags: review?(rnewman) → review+
Assignee | ||
Comment 2•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/f8b8ad4abc7d
Comment 3•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f8b8ad4abc7d
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•