test_load_modules and bagheera* tests run for builds without MOZ_SERVICES_HEALTHREPORT after bug 1148990

RESOLVED FIXED in Firefox 40

Status

Cloud Services
Firefox: Common
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: aryx, Assigned: aryx)

Tracking

unspecified
mozilla40
Points:
---

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(1 attachment)

Created attachment 8588281 [details] [diff] [review]
patch, v1

https://hg.mozilla.org/mozilla-central/rev/042755670a6d from bug 1148990 lets the application only ship with bagheeraclient.js and bagheeraserver.js if MOZ_SERVICES_HEALTHREPORT is 1/true but always tries to import them and run theirs tests if the OS isn't Android. This fails if one build without MOZ_SERVICES_HEALTHREPORT (like Thunderbird at the moment). So this patch adds the health report condition to the tests.
Attachment #8588281 - Flags: review?(rnewman)
Comment on attachment 8588281 [details] [diff] [review]
patch, v1

Review of attachment 8588281 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the catch!
Attachment #8588281 - Flags: review?(rnewman) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/f8b8ad4abc7d
https://hg.mozilla.org/mozilla-central/rev/f8b8ad4abc7d
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.