115124 - ###!!! ASSERTION: Can't use |Truncate()| to make a string longer.: 'aNewLength <= this->Length()', file ../../dist/include/string/nsAString.h, line 506

Status: RESOLVED FIXED

(Core :: XBL, defect)

Description

[timeless]

#6  0x282ce615 in nsACString::Truncate (this=0xbfbfd69c, aNewLength=4294967295) at ../../dist/include/string/nsAString.h:506
#7  0x292f1a31 in nsXBLService::GetBindingInternal (this=0x81e0b80, aBoundElement=0x880bbc0, aURLStr=@0xbfbfd914, aPeekOnly=0, aIsReady=0xbfbfd73c, aResult=0xbfbfd980)
    at /home/timeless/mozilla/content/xbl/src/nsXBLService.cpp:938

Tingley pointed out that aNewLength is -1.

#7  0x292f1a31 in nsXBLService::GetBindingInternal (this=0x81e0b80, aBoundElement=0x880bbc0, aURLStr=@0xbfbfd914, aPeekOnly=0, aIsReady=0xbfbfd73c, aResult=0xbfbfd980)
    at /home/timeless/mozilla/content/xbl/src/nsXBLService.cpp:938
938       uri.Truncate(indx);
(gdb) list
933       // XXX Obtain the # marker and remove it from the URL.
934       nsCAutoString uri(aURLStr);
935       PRInt32 indx = uri.RFindChar('#');
936       nsCAutoString ref;
937       uri.Right(ref, uri.Length() - (indx + 1));
938       uri.Truncate(indx);
939
940       nsCOMPtr<nsIDocument> boundDocument;
941       aBoundElement->GetDocument(*getter_AddRefs(boundDocument));
942
uri doesn't contain '#'

Comment 1

[timeless]

Attachment: if # isn't found, return error

Comment 2

[timeless]

Comment on attachment 61624 [details] [diff] [review]
if # isn't found, return error

please ignore the second block. i've been typoing near xbl a bit so the number
of outstanding patches to it is growing.

Comment 3

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 61624 [details] [diff] [review]
if # isn't found, return error

r=pink

Comment 4

[Alec Flett]

Comment on attachment 61624 [details] [diff] [review]
if # isn't found, return error

sr=alecf

Comment 5

[Brendan Eich [:brendan]]

Comment on attachment 61624 [details] [diff] [review]
if # isn't found, return error

spaces around operators, please (as the prevailing style does, and as Mozilla
style almost always does).

Fix that, and a=[e-mail]

Comment 6

[timeless]

fix checked in with spaces