If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Add Fx Family Nav to old Sync page

RESOLVED FIXED

Status

www.mozilla.org
General
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: Habber, Assigned: jpetto)

Tracking

Production
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [kb=1712608])

Attachments

(1 attachment)

44 bytes, text/x-github-pull-request
Details | Review | Splinter Review
(Reporter)

Description

3 years ago
While doing user testing, a user in the /ro/ locale clicked on Sync in the Firefox Family Nav. When the /sync page loaded for this user, the Firefox Family Nav was not retained. 

Here is a screenshot of what he saw during the user test http://cl.ly/image/2D2V1V1D0Z1L

You can see that the Sync page in his language has the old navigation.

Could this be an isolated case for this locale or could we have this issue in other locales as well?
(Assignee)

Updated

3 years ago
Assignee: nobody → jon
OS: Mac OS X → All
Hardware: x86 → All
Whiteboard: [kb=1712608]
(Assignee)

Comment 1

3 years ago
Created attachment 8588611 [details] [review]
GitHub PR

Ah, some locales still don't have the new Sync page translated. These locales are getting the old Sync page, which did not get the Fx family nav. This PR addresses the issue.
(Assignee)

Updated

3 years ago
Summary: Firefox Family Nav: User went to Sync page in /ro/ locale and it did not retain Fx Family navigation → Add Fx Family Nav to old Sync page

Comment 2

3 years ago
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/9e9ffcc2ea858048f9889efd6df92e335ffcd5f2
Bug 1151355. Fx family nav on old sync pages.

- Bug 1150558. Padding/spacing on desktop subnav items.

https://github.com/mozilla/bedrock/commit/cd45068c1c3574e2f93332ca2e0d983a56f1a055
Merge pull request #2894 from mozilla/bug-1151355-fx-nav-old-sync-pages

Bug 1151355. Fx family nav on old sync pages.
(Assignee)

Updated

2 years ago
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.