1151360 - 5.1 AAC doesn't play

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Jean-Yves Avenard [:jya]]

File from https://bugzilla.mozilla.org/attachment.cgi?id=8496419 (bug 1073805) doesn't play anymore.

This has regressed.

Comment 1

[Jean-Yves Avenard [:jya]]

Plays in aurora (38.0a2)

Comment 2

[Alice0775 White]

[Tracking Requested - why for this release]: 
Regression Since Firefox 38.
It worth fixing for next ESR38.


Pushlog: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=3824a4591067&tochange=1b7d0845db2a

Regressed by: Bug 1146222 or Bug 1143491

Comment 3

[Jean-Yves Avenard [:jya]]

Attachment: Allow playback of extended AAC profile audio track

Bug 1146222 introduced a regression. the aac profile can only be 1 to 4. AAC with in-band SBR will have an extended profile set.

Comment 4

[Jean-Yves Avenard [:jya]]

The regression is an unwanted consequence of an originally buggy code that was always returning true (any audio track would have been considered valid)

Comment 5

[Jean-Yves Avenard [:jya]]

As 1146222 was uplifted. This one would have to be uplifted too.

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Tracking for 38+.

Comment 7

[Jean-Yves Avenard [:jya]]

Attachment: Allow playback of extended AAC profile audio track

Allow extended AAC profile to play

Comment 8

[Jean-Yves Avenard [:jya]]

Comment on attachment 8588503 [details] [diff] [review]
Allow playback of extended AAC profile audio track

askin k17e instead, as karlt doesn't appear to be available at present

Comment 9

[Jean-Yves Avenard [:jya]]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/aa2fa3cb933b

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/aa2fa3cb933b

Comment 11

[Sylvestre Ledru [:Sylvestre]]

Jean-Yves, I think we want this to be fixed for 38. Could you fill the uplift request to aurora and beta? Thanks

Comment 12

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8588825 [details] [diff] [review]
Allow playback of extended AAC profile audio track

Approval Request Comment
[Feature/regressing bug #]: Bug 1151360, support 5.1 Audio
[User impact if declined]: Some AAC audio files with "extended profile" won't play
[Describe test coverage new/current, TreeHerder]: Jya has tested locally.
[Risks and why]: Seems pretty low; we'll means we'll attempt to play files that we used to play, so it should work.
[String/UUID change made/needed]: None.

Comment 13

[Chris Pearce [:cpearce (Not reading bugmail)]]

Jya: are you able to produce an MP4A/AAC file with that hits this code path and add it to our playback tests so that we don't regress this again? Thanks.

Comment 14

[Jean-Yves Avenard [:jya]]

This isn't necessary in beta as bug 1146222 wasn't uplifted

Comment 15

[Jean-Yves Avenard [:jya]]

actually, bug 1146222 needs to be uplifted as code that were uplifted in beta introduced the crash fixed in 114622

Comment 16

[Chris Pearce [:cpearce (Not reading bugmail)]]

(In reply to Jean-Yves Avenard [:jya] from comment #15)
> actually, bug 1146222 needs to be uplifted as code that were uplifted in
> beta introduced the crash fixed in 114622

bug 1146222 was uplifted to 38 when 38 was on Aurora.

Comment 17

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8588825 [details] [diff] [review]
Allow playback of extended AAC profile audio track

Should be in 38 beta 3

Comment 18

[Jean-Yves Avenard [:jya]]

remote:   https://hg.mozilla.org/releases/mozilla-aurora/rev/07918178025b
remote:   https://hg.mozilla.org/releases/mozilla-beta/rev/a24bdacce4cc

Comment 19

[sakibsohag1993]

fixed

Comment 20

[shohug01]

Status: ASSIGNED → RESOLVED
Resolution: --- → FIXED

Comment 21

[Daniel Holbert [:dholbert]]

Please don't just add extra, redundant comments to bugs.

If you guys are trying to test out bugzilla, please use https://landfill.bugzilla.org/.

This bugzilla instance here is used for real work; your extra comments cause emails to be sent to people who are watching the bug and/or the component, and they waste people's time.

Comment 22

[Hossain Al Ikram [:ikram] (QA Contact)]

Reproduced with Firefox Nightly 24.0a1 (2013-05-15) with the instruction from comment 0 and on Windows 7 x64.

Verified as fixed with Firefox Aurora 40.0a2  (Build ID: 20150526004004) 

Mozilla/5.0 (Windows NT 6.1; WOW64; rv:40.0) Gecko/20100101 Firefox/40.0

Comment 23

[Kazi Nuzhat Tasnem]

 I have reproduced  this bug with Firefox nightly (40.0a1) with the instruction from comment 0 and on Windows 7 x64.

Verified as fixed with Firefox release 38.0.1 (Build ID: 20150513174244) , latest beta  39.0 (Build ID: 20150523155636) and latest Aurora 40.0a2 (Build ID: 20150526004004)
 
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Firefox/38.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:39.0) Gecko/20100101 Firefox/39.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:40.0) Gecko/20100101 Firefox/40.0

Comment 24

[Saheda Reza [:Antora]]

I reproduce the bug, 5.1 AAC didn't play on Firefox Nightly windows 8.1(32bit)

Build ID 	20150405030238
User Agent 	Mozilla/5.0 (Windows NT 6.3; rv:40.0) Gecko/20100101 Firefox/40.0

It properly played on Latest nightly 

Build ID 	20150724030210
User Agent 	Mozilla/5.0 (Windows NT 6.3; rv:42.0) Gecko/20100101 Firefox/42.0

[bugday-20150724]