All users were logged out of Bugzilla on October 13th, 2018

mozinfo.py fails 'bits' undefined on powerpc64

RESOLVED FIXED in Firefox 40

Status

RESOLVED FIXED
4 years ago
8 months ago

People

(Reporter: stevensn, Assigned: ahal)

Tracking

unspecified
mozilla40
PowerPC
Linux

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(3 attachments, 1 obsolete attachment)

(Reporter)

Description

4 years ago
mozinfo.py is failing on ppc64 because 'bits' is not defined in the dictionary.

Bug 1142050 populates bits for ppc and ppc64 but not 'powerpc64' or 'powerpc'  It also is missing sparc and possibly other platforms.
(Reporter)

Updated

4 years ago
Blocks: 1142050
(Reporter)

Comment 1

4 years ago
Created attachment 8588498 [details] [diff] [review]
add more platforms to mozinfo.py
(Reporter)

Comment 2

4 years ago
Comment on attachment 8588498 [details] [diff] [review]
add more platforms to mozinfo.py

Landry,

Have I missed any platforms that you are aware people are building on?

My thinking is that this should default to 32 bits if the platform isn't in the list instead of failing.
Flags: needinfo?(landry)
On OpenBSD/ppc, TARGET_CPU is 'powerpc' too. Maybe we should also add various mips* targets... glandium usually targets more (alpha?s390?) with debian :)
Flags: needinfo?(landry) → needinfo?(mh+mozilla)
I'm not overly concerned with covering 100% of CPUs here. Fix what's broken for you, and if there are others that you know are being used that's fine too, but I'm fine with this only supporting architectures that people are actively using.
(Assignee)

Comment 5

4 years ago
Bug 1142050 doesn't change 'bits' at all.
No longer blocks: 1142050
(Reporter)

Comment 6

4 years ago
Andrew, doesn't https://hg.mozilla.org/mozilla-central/rev/0b0d3ba11869  add the guess_platform function?
(Reporter)

Comment 7

4 years ago
branislav, which MIPS cpu targets are you supporting (and are they 64 or 32 bits)
Flags: needinfo?(branislav.rankov)
(Assignee)

Comment 8

4 years ago
(In reply to Steve Singer (:stevensn) from comment #6)
> Andrew, doesn't https://hg.mozilla.org/mozilla-central/rev/0b0d3ba11869  add
> the guess_platform function?

Oh I see what you mean. Bug 1142050 uses 'bits' which causes this failure, but it doesn't populate anything under the bits section. Sorry, the wording in comment 0 confused me a bit.
Blocks: 1142050
platform_guess is really only useful for platforms built on Mozilla automation. I'd rather fix those functions to return an empty string on non "supported" platforms, than adding partial support for some classes of hardware.
Flags: needinfo?(mh+mozilla)
For MIPS, you should add:
- mips and mipsel as 32 bit
- mips64 and mips64el as 64 bit.
Flags: needinfo?(branislav.rankov)
(Assignee)

Comment 11

4 years ago
Created attachment 8589079 [details]
MozReview Request: bz://1151370/ahal

/r/6693 - Bug 1151370 - Only guess platform/buildtype in mozinfo.py if processor is known, r=ted

Pull down this commit:

hg pull -r 3cbb0cb504bf17d91936e2b995dac6c8d9f8badc https://reviewboard-hg.mozilla.org/gecko/
Attachment #8589079 - Flags: review?(ted)
(Assignee)

Comment 12

4 years ago
Apologies for the regression, the above should be all you need. I agree with ted and glandium that there's not much value in adding additional processors unless they're actually needed somewhere. The other patch just wrongfully assumed that 'bits' was always set.

Comment 13

4 years ago
Created attachment 8591322 [details] [diff] [review]
MIPS-Add-support-for-mozinfo.patch
Attachment #8591322 - Flags: review?(khuey)
Was something commited in the end ? I see ted said 'ship it' on the reviewboard link for attachment 8589079 [details] but nothing landed, as a build on ppc still fails as of now:

 1:00.30   File "/home/landry/src/mozilla-central/python/mozbuild/mozbuild/mozinfo.py", line 101, in guess_platform
 1:00.30     elif d['bits'] == 64:
 1:00.30 KeyError: 'bits'
(Assignee)

Comment 15

4 years ago
(In reply to Landry Breuil (:gaston) from comment #14)
> Was something commited in the end ? I see ted said 'ship it' on the
> reviewboard link for attachment 8589079 [details] but nothing landed

Oh weird, usually clicking Ship It! is supposed to flip the bugzilla attachment to an r+ but that didn't happen in this case for some reason. I'll land it now.
(Assignee)

Comment 17

4 years ago
Comment on attachment 8589079 [details]
MozReview Request: bz://1151370/ahal

Mozreview didn't flip the r+ for some reason. Landed:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=f1a49ef21a1c
Attachment #8589079 - Flags: review?(ted) → review+
https://hg.mozilla.org/mozilla-central/rev/f1a49ef21a1c
Assignee: nobody → ahalberstadt
Status: NEW → RESOLVED
Last Resolved: 4 years ago
status-firefox40: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40

Updated

4 years ago
Keywords: checkin-needed
I'm not 100% sure but with what was commited in https://hg.mozilla.org/mozilla-central/rev/f1a49ef21a1c attachment #8591322 [details] [diff] [review] is not needed now.
Keywords: checkin-needed
(Assignee)

Comment 20

3 years ago
Comment on attachment 8589079 [details]
MozReview Request: bz://1151370/ahal
Attachment #8589079 - Attachment is obsolete: true
Attachment #8619975 - Flags: review+
(Assignee)

Comment 21

3 years ago
Created attachment 8619975 [details]
MozReview Request: Bug 1151370 - Only guess platform/buildtype in mozinfo.py if processor is known, r=ted

Updated

8 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.