1151372 - non-ion assertion due to stack alignment mismatch

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Steve Singer (:stevensn)]

Build failure on a non-ion platform with

js/src/asmjs/AsmJSValidate.cpp:8615:5: error: static assertion failed: subsumes
     static_assert(AsmJSStackAlignment >= JitStackAlignment, "subsumes");
     ^

JitStackAlignment is 8 (after bug 1130089) but AsmJSStackAlignment is only for
for the none/non-ion jit

Comment 1

[Steve Singer (:stevensn)]

Attachment: fix alignment mismatch

Comment 2

[Steve Singer (:stevensn)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=02211036c2d9

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0c771aa45448

Comment 4

[Steve Singer (:stevensn)]

https://hg.mozilla.org/mozilla-central/rev/0c771aa45448

Comment 5

[Steve Singer (:stevensn)]

Attachment: jit_stack_alignment_match.diff

Approval Request Comment
[Feature/regressing bug #]: 1130089
[User impact if declined]: non-ion platforms won't build
[Describe test coverage new/current, TreeHerder]: Included/tested on m-c
[Risks and why]: Low risk the none jit backend is NPOTB-tier1
[String/UUID change made/needed]:

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8591304 [details] [diff] [review]
jit_stack_alignment_match.diff

Sounds low risk if I understand you correctly. And we want you to be able to build!

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Of course, *now* notice that this landed with the wrong bug number.
https://hg.mozilla.org/releases/mozilla-aurora/rev/9320548724ae