1151413 - executeSoon should set async caller

Status: VERIFIED FIXED

(DevTools :: Framework, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

|makeInfallible| should use |callFunctionWithAsyncStack| to connect the function it runs with the outer environment.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Looks like `makeInfallible` is actually fine itself, but `executeSoon` is the one with async behavior (and it happens to *call* `makeInfallible` which is what appears in the stack trace later.)

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: MozReview Request: Bug 1151413 - Set async caller in DevToolsUtils.executeSoon r=ejpbruel

Review commit: https://reviewboard.mozilla.org/r/28585/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/28585/

Comment 3

[Eddy Bruel [:ejpbruel]]

Comment on attachment 8700115 [details]
MozReview Request: Bug 1151413 - Set async caller in DevToolsUtils.executeSoon r=ejpbruel

https://reviewboard.mozilla.org/r/28585/#review25427

Looks good to me. Great that you added a test for this! I just have one comment about the test. r+ with that addressed.

::: devtools/shared/tests/unit/test_executeSoon.js:18
(Diff revision 1)
> +  if (!Services.prefs.getBoolPref("javascript.options.asyncstack")) {

Are async stacks enabled by default? If we ever decide to disable them, this test will always pass. Wouldn't it be better to always enable async stacks for this test, and then reset the pref to its original value afterwards?

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

https://reviewboard.mozilla.org/r/28585/#review25427

> Are async stacks enabled by default? If we ever decide to disable them, this test will always pass. Wouldn't it be better to always enable async stacks for this test, and then reset the pref to its original value afterwards?

They are only enabled on desktop, and only for non-release channels, by default.  Anyway, what you say seems fine, I'll update the test.

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8700115 [details]
MozReview Request: Bug 1151413 - Set async caller in DevToolsUtils.executeSoon r=ejpbruel

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/28585/diff/1-2/

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0df8478ca614

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0df8478ca614

Comment 8

[Mayur Patil]

[bugday-20160323]

Status: RESOLVED,FIXED -> UNVERIFIED

Comments:
STR: Developer specific testing

Component: 
Name 			Firefox
Version 		46.0b4
Build ID 		20160322075646
Update Channel 	        beta
User Agent 		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS                      Windows 7 SP1 x86_64