Closed Bug 1151456 Opened 9 years ago Closed 9 years ago

Redundant gray padding in Settings page

Categories

(Marketplace Graveyard :: Consumer Pages, defect)

Product:
Marketplace Graveyard
Component:
Consumer Pages
Version:
Avenir
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
2015-04-07

People

(Reporter: vvalentina, Assigned: mstriemer)

References

(
URL
)

Details

(Keywords: regression) 

Steps to reproduce:
1. Load MP-stage “Settings” page https://marketplace.allizom.org/settings 

Expected results:
There are no display or layout issues.

Actual results:
A gray padding appears between Sign in/Register buttons and Newsletter section.

Notes/Issues:
Verified on FF40(Win 7). Issue is reproducing on MP-dev and MP-stage.
Screencast for this issue: http://screencast.com/t/JX7uihqpRT
Keywords: regression
https://github.com/mozilla/fireplace/pull/1114
Assignee: nobody → mstriemer
Status: NEW → ASSIGNED
https://github.com/mozilla/fireplace/commit/b473ec17e762da8f9e5af075cdb7cfea30fac7ea
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Verified as fixed on MP-dev FF40(Win 7).
Postfix screenshot: http://screencast.com/t/3e8D1dDg9

But, after signing out, there is also a gray padding; don't know if intended or not?
Please see screenshot: http://screencast.com/t/ynsvMpp6b
Flags: needinfo?(mstriemer)
I believe that was added for fennec since there was a platform bug there when the page was shorter than the viewport. So perhaps expected but not necessarily intentional.

The fennec bug is bug 976531. I think it needs to stay for now.
Flags: needinfo?(mstriemer)
(In reply to Mark Striemer [:mstriemer] from comment #4)
> I believe that was added for fennec since there was a platform bug there
> when the page was shorter than the viewport. So perhaps expected but not
> necessarily intentional.
> 
> The fennec bug is bug 976531. I think it needs to stay for now.

Closing bug.
Status: RESOLVED → VERIFIED
The gray padding, from Settings page, returns, together with the new main nav.
The reported issue is reproducing on MP-dev after new nav was set.
Reopening.
Blocks: 1148114
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
We should only do this at mobile width when we have the sidebar menu.
https://github.com/mozilla/fireplace/commit/b9bd6bc4202de756b8201cece4b6b03f4c22cc33
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
Verified as fixed on MP-dev FF40(Win 7).
Postfix screenshot: http://screencast.com/t/wlOat1bTT
Closing bug.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.