1151480 - A web page using BroadcastChannel crashes the browser after navigating to it

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Salvador de la Puente González [:salva]]

STR:
1. Tap on the search bar
2. Navigate to http://lodr.github.io/bcc-crash

Expected:
The web loads properly.

Actual:
The web crashes and closes the browser.

Comment 1

[Salvador de la Puente González [:salva]]

Hi Andrea

Do you know who is in charge of this part? I would plan to use broadcast to communicate the offliner worker [1] in order to enable updating capabilities on applications. Francisco's serviceworkerware [2] is using it as well.

[1] https://github.com/lodr/offliner/tree/concept
[2] https://github.com/arcturus/serviceworkerware

Comment 2

[Andrea Marchesini [:baku]]

Tell me more. I cannot reproduce the crash.

Comment 3

[Salvador de la Puente González [:salva]]

Trying on the Flame device (Nightly seems to work and I did not try in b2g desktop), navigating to http://lodr.github.io/bcc-crash causes the browser to close.

Comment 4

[Andrea Marchesini [:baku]]

I cannot reproduce it with the current nightly. Can you tell me which version crashes? Can it be that his issue is already fixed?

Comment 5

[Salvador de la Puente González [:salva]]

Ups, you must load some custom prefs to Gaia:

user_pref('dom.caches.enabled', true);
user_pref('dom.serviceWorkers.enabled', true);
user_pref('dom.serviceWorkers.testing.enabled', true);
user_pref('network.disable.ipc.security', true);

Comment 6

[Andrea Marchesini [:baku]]

Attachment: bc.patch

After the latest changed in BroadcastChannel API, for b2g we use the manifest URL as origin.
The problem is that the nsIPrincipal->CheckMayLoad() fails with such URI.
This patch compare the manifestURL with the origin if the principal has an appId.

Comment 7

[(no longer active)]

Comment on attachment 8589190 [details] [diff] [review]
bc.patch

Review of attachment 8589190 [details] [diff] [review]:
-----------------------------------------------------------------

::: ipc/glue/BackgroundParentImpl.cpp
@@ +300,5 @@
> +        mContentParent = nullptr;
> +      }
> +
> +      nsRefPtr<ContentParent>& mContentParent;
> +    };

This is reimplementing AutoRestore.  Please use that instead.

Comment 8

[Andrea Marchesini [:baku]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d66905fa5718

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d66905fa5718