1151482 - Dev Edition Theme: Text on Windows URL bar is black with dark background

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Brian Grinstead [:bgrins]]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1121543#c2 and https://bugzilla.mozilla.org/attachment.cgi?id=8587906.  Most likely the change to a lightweight theme is causing a new selector to apply to the text color.

Comment 1

[Brian Grinstead [:bgrins]]

It's due to this rule [0] in windows/browser.css:

  #urlbar:-moz-lwtheme,
  .searchbar-textbox:-moz-lwtheme {
    background-color: rgba(255,255,255,.8);
    @navbarTextboxCustomBorder@
    color: black;
  }

[0]: https://dxr.mozilla.org/mozilla-central/source/browser/themes/windows/browser.css#1137

Comment 2

[Brian Grinstead [:bgrins]]

Attachment: devedition-windows-urlbar.patch

I don't think there is any reason in particular this property wasn't !important like the others in this block, expect that it wasn't needed.  Now that this is a :-moz-lw-theme, we do need it for Windows support.

Comment 3

[:Gijs (he/him)]

Comment on attachment 8588735 [details] [diff] [review]
devedition-windows-urlbar.patch

Review of attachment 8588735 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me, sorry for the (long-weekend-holiday-catchup-induced) delay!

Comment 4

[Brian Grinstead [:bgrins]]

https://hg.mozilla.org/integration/fx-team/rev/6c7eb5b4df47

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6c7eb5b4df47

Comment 6

[Jia Yuan Lo]

Thanks guys, the bug is fixed with the latest update.