Closed
Bug 1151509
Opened 9 years ago
Closed 9 years ago
Implement the front-end side of the warning about add-ons detected as no longer signed during the periodic check
Categories
(Toolkit :: Add-ons Manager, defect, P1)
Toolkit
Add-ons Manager
Tracking
()
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: mossop, Assigned: dao)
References
Details
(Whiteboard: [fxsearch][searchhijacking])
Attachments
(2 files, 2 obsolete files)
24.96 KB,
patch
|
mossop
:
review+
|
Details | Diff | Splinter Review |
3.56 KB,
patch
|
mossop
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Reporter | ||
Updated•9 years ago
|
Summary: Implement the UX side → Implement the UX side of the warning about add-ons detected as no longer signed during the periodic check
Reporter | ||
Updated•9 years ago
|
Reporter | ||
Updated•9 years ago
|
Flags: qe-verify?
Flags: firefox-backlog+
Reporter | ||
Updated•9 years ago
|
Summary: Implement the UX side of the warning about add-ons detected as no longer signed during the periodic check → Implement the front-end side of the warning about add-ons detected as no longer signed during the periodic check
Reporter | ||
Comment 1•9 years ago
|
||
I'm working on the back-end piece of this in bug 1151511. I'm thinking a simple observer notification containing the IDs of add-ons to warn about would make sense for communicating to the front-end here but I'm open to alternatives.
Reporter | ||
Updated•9 years ago
|
Points: --- → 5
Flags: qe-verify? → qe-verify+
Reporter | ||
Updated•9 years ago
|
Whiteboard: [fxsearch][searchhijacking]
Reporter | ||
Updated•9 years ago
|
Priority: -- → P1
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → dao
Status: NEW → ASSIGNED
Iteration: --- → 40.3 - 11 May
Assignee | ||
Comment 2•9 years ago
|
||
I'll work on a test tomorrow
Attachment #8602926 -
Flags: review?(dtownsend)
Reporter | ||
Comment 3•9 years ago
|
||
Some styling problems on OSX here: https://www.dropbox.com/s/0w5tg98m1nbuseu/Screenshot%202015-05-07%2017.03.50.png?dl=0
Reporter | ||
Comment 4•9 years ago
|
||
Comment on attachment 8602926 [details] [diff] [review] patch Review of attachment 8602926 [details] [diff] [review]: ----------------------------------------------------------------- This is good but there are some odd behaviours. If you go to the extensions list, click to show unsigned extensions, click appearance then click back you're back to the full extensions view. I'm not a big fan of the callback before view change and I think there is a better way. Instead just load the view as "addons://list/extensions?unsigned=true". At the top of gListView.show if aType ends with "?unsigned=true" strip it off and set showOnlyDisabledUnsigned to true. At some point it might make sense to do actual url query parameter expansion but as this is the only thing we care about right now straight string matching is fine. That should make back/forward behave as expected and mean you don't need the additional showDisabledUnsignedAddons function and callback support in browser.js. ::: toolkit/locales/en-US/chrome/mozapps/extensions/extensions.dtd @@ +22,5 @@ > > <!ENTITY cmd.back.tooltip "Go back one page"> > <!ENTITY cmd.forward.tooltip "Go forward one page"> > > +<!ENTITY showUnsignedExtensions.button.label "Some exitensions could not be verified"> s/exitensions/extensions/ ::: toolkit/mozapps/extensions/content/extensions.js @@ +2700,5 @@ > + devManualLink.setAttribute("href", > + Services.prefs.getCharPref("xpinstall.signatures.devInfoURL")); > + } catch (e) { > + document.getElementById("signing-dev-info").hidden = true; > + } All this link initialisation stuff should just go into gListView.initialize
Attachment #8602926 -
Flags: review?(dtownsend) → review-
Assignee | ||
Comment 5•9 years ago
|
||
I was afraid that messing with the viewId strings would break too many expectations about these strings, but it seems alright. I just had to change gCategories.select.
Attachment #8602926 -
Attachment is obsolete: true
Attachment #8603195 -
Flags: review?(dtownsend)
Assignee | ||
Updated•9 years ago
|
Attachment #8603195 -
Attachment description: patch → patch v2
Reporter | ||
Comment 6•9 years ago
|
||
Comment on attachment 8603195 [details] [diff] [review] patch v2 Review of attachment 8603195 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, I'm still seeing the styling issue from comment 3 though.
Attachment #8603195 -
Flags: review?(dtownsend) → review+
Assignee | ||
Comment 7•9 years ago
|
||
(In reply to Dave Townsend [:mossop] from comment #6) > Comment on attachment 8603195 [details] [diff] [review] > patch v2 > > Review of attachment 8603195 [details] [diff] [review]: > ----------------------------------------------------------------- > > Looks good, I'm still seeing the styling issue from comment 3 though. Missed that comment. Looks like the alert-icon class I set on the button is broken on OS X. I've removed it in this patch. Do you still see issues with the button?
Attachment #8603195 -
Attachment is obsolete: true
Attachment #8603396 -
Flags: review?(dtownsend)
Reporter | ||
Comment 8•9 years ago
|
||
Comment on attachment 8603396 [details] [diff] [review] patch v3 Review of attachment 8603396 [details] [diff] [review]: ----------------------------------------------------------------- Yeah that looks better
Attachment #8603396 -
Flags: review?(dtownsend) → review+
Assignee | ||
Comment 9•9 years ago
|
||
Attachment #8603424 -
Flags: review?(dtownsend)
Reporter | ||
Updated•9 years ago
|
Attachment #8603424 -
Flags: review?(dtownsend) → review+
Comment 11•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ac36a281c5c1
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Updated•9 years ago
|
QA Contact: vasilica.mihasca
Comment 12•9 years ago
|
||
Dave, does this bug need manual testing? If yes, can you provide me some steps in order to verify it?
Flags: needinfo?(dtownsend)
Reporter | ||
Comment 13•9 years ago
|
||
This is a challenge to simulate manually, given that we have automated tests for the only part that is different to bug 1151507 I think we don't need to manually check this bug.
Flags: qe-verify-
Flags: qe-verify+
Flags: needinfo?(dtownsend)
You need to log in
before you can comment on or make changes to this bug.
Description
•