1151530 - Margins and font weights inconsistent with mockups in awesome screen

Status: RESOLVED FIXED

(Firefox for iOS :: Theme & Visual Design, defect)

Description

[Brian Nicholson (:bnicholson)]

Next to the mockup, it looks like a couple things have regressed in the awesome screen styling over the past couple of weeks:
* The margins for the favicons look too wide
* The font weight looks too bold
* The site titles/URLs aren't vertically centered in the cells

Screenshot from 2 weeks ago: https://www.dropbox.com/s/pkmrkwqbk0ki61l/Screenshot%202015-04-06%2010.21.52.png?dl=0

Screenshot from today: https://www.dropbox.com/s/tnac5nfm5o237yt/Screenshot%202015-04-06%2010.20.33.png?dl=0

Comment 1

[Darrin Henein [:darrin]]

I would fix the margins and the vertical alignment, but I changed the font weight of the titles in the two-line cell and just haven't updated the mockups. I think the medium weight I changed it too looks much better on device, and is easier to scan.

Comment 2

[Brian Nicholson (:bnicholson)]

(In reply to Darrin Henein [:darrin] from comment #1)
> I would fix the margins and the vertical alignment, but I changed the font
> weight of the titles in the two-line cell and just haven't updated the
> mockups.

Ah, OK. Thought some of those changes may have been intentional, but just wasn't sure which ones. Thanks for the clarification!

Comment 3

[Brian Nicholson (:bnicholson)]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/435

Darrin, what do you think of these tweaks?

Comment 4

[Darrin Henein [:darrin]]

Attachment: empty cells

Looks great Brian! Is it an easy fix to make empty cells have the same margin/inset (see screenshot)? Bookmarks especially looks off, and has been pointed out by a few testers already.