1151599 - Bump file size limit up to 250 Mb

Status: RESOLVED FIXED

(Marketplace Graveyard :: Validation, defect, P3)

Description

[:Harald Kirschner :digitarald]

We pitched Marketplace at GDC and our business development team is having several Unity games in the pipelines. The first submissions are coming in that hit the 100 Mb file size limit. As the limit was added with FxOS in mind and not desktop + games need to get this out of the way asap.

I would suggest bumping the filesize to at least 200 Mb.

For further discussion: Android solves this by allowing splitting APKs where in case of unity one shared APK contains the game code and other APKs are generated with game assets in various qualities/sizes.

Comment 1

[:Harald Kirschner :digitarald]

ni? on D&W

Comment 2

[Mathieu Pillard [:mat]]

FWIW this might not be as straightforward as just raising the limit ; the validator might also choke and time out on big archives containing a lot of code to process (and the timeout is already pretty big).

(And yeah, we should figure out something to allow splitting the packages in order not to have enormous single file uploads/downloads)

Comment 3

[Mark Striemer [:mstriemer]]

This is set in https://github.com/mozilla/zamboni/blob/master/mkt/constants/submit.py.

I don't think it's going to be JS that is causing these files to be bigger than 100MB although I could be wrong. I'm assuming it will mostly be images and videos that put bundles over the limit.

100MB is already lots of room to put a ton of JS but it's probably worth putting Unity and Unreal lib files in our safe list as I'm guessing those files are probably pretty hefty.

Comment 4

[Wil Clouser [:clouserw]]

If we already don't validate files over 1MB I wonder if this limit is really useful to us.  It could just as easily choke on something at 100MB as it can at 250MB.  Just thinking out loud - either way, let's increase this to 250MB for now and we can talk about how to scale it in the future.

Comment 5

[Wil Clouser [:clouserw]]

https://github.com/mozilla/zamboni/commit/ca7a708a4787ac551b14dd649ff53778a9577b57

I'm marking this QA- because Harald is going to try it as soon as it lands, I imagine.

Comment 6

[:Harald Kirschner :digitarald]

Upload worked and validation didn't fail because of archive file size but some file size limit for files within the archive which isn't even mentioned or explained: https://cloudup.com/cLB7rNTH144

Comment 7

[Wil Clouser [:clouserw]]

Interesting.  It looks like that is set at https://github.com/mozilla/zamboni/blob/master/mkt/settings.py#L706

PR @ https://github.com/mozilla/zamboni/pull/3054

Comment 8

[Wil Clouser [:clouserw]]

https://github.com/mozilla/zamboni/commit/580d2e83969b287f88a8f235cf572008df572f7a

This is before 11 so I'd expect it to get in the tag for next Tuesday