1151606 - Stream atoms instead of raw pointers for native functions in tracked optimizations

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Description

[Shu-yu Guo [:shu]]

Instead of streaming the raw JSNative function pointer, stream the JSFunction's displayAtom if one exists.

Comment 1

[Shu-yu Guo [:shu]]

Attachment: Stream atoms instead of raw pointers for native functions in tracked optimizations.

Comment 2

[Shu-yu Guo [:shu]]

Comment on attachment 8588851 [details] [diff] [review]
Stream atoms instead of raw pointers for native functions in tracked optimizations.

Review of attachment 8588851 [details] [diff] [review]:
-----------------------------------------------------------------

Forgot to request review...

Comment 3

[Kannan Vijayan [:djvj]]

Comment on attachment 8588851 [details] [diff] [review]
Stream atoms instead of raw pointers for native functions in tracked optimizations.

Review of attachment 8588851 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/OptimizationTracking.cpp
@@ +1215,5 @@
>              //   Dl_info info;
>              //   if (dladdr(addr, &info) != 0)
>              //       offset = uintptr_t(addr) - uintptr_t(info.dli_fbase);
>              //
> +            char locationBuf[16];

If we're printing a pointer into this, and a pointer can be 8 bytes, then 8*2 hexchars + 1 terminal char is 17 maximally used.  Let's just set this to 20 and avoid any issues.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bab25fb63a20