1151625 - [Camera][Volume Rocker] Pressing the volume button during a self timer countdown will not cancel the countdown

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

Description:
When the user has the Self-Timer enabled in the camera app, tapping the capture buton will cancel an active countdown. When the user uses the volume rocker to initiate the timer countdown, they cannot press the volume rocker again to cancel the countdown. This is an inconsistency within the camera app


Repro Steps:
1) Update a Flame to 20150406010204
2) Open Camera app
3) Open the options panel, and change the self timer to 2, 5 or 10 seconds
4) Press the volume button
5) Press the volume button again


Actual:
The timer will start counting down but will not cancel when pressing the volume button


Expected:
When the timer is counting down and the volume button is pressed, the timer is canceled and the picture is not taken

Environmental Variables:
Device: Flame 3.0 (319mb)(Kitkat)(Full Flash)
Build ID: 20150406010204
Gaia: ef61ebbe5de8c2c9fc2a8f74a12455044c3b82e9
Gecko: 4fe763cbe196
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 40.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0


Repro frequency: 8/8
See attached: Logcat, Video - https://youtu.be/yjCHewZfKwU

Comment 1

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

The volume rocker to take a picture feature was not implemented on 2.2 or earlier, no branch checks to be done.

Comment 2

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

This issue seems to be a result of the fix done on bug 1144830

Comment 3

[Peter Bylenga [:PBylenga]]

NI on component owner to take a look.

Comment 4

[No-Jun Park [:njpark]]

Mike, is this per design or should we fix this inconsistency?

Comment 5

[Mike Habicher [:mikeh] (high bugzilla latency)]

Over to UX.

Comment 6

[Tiffanie Shakespeare [:tif]]

Sorry for the delay guys - I was mega sick. 

The volume rocker should start/stop the timer if that is enabled.

Please see updated spec:https://github.com/mozilla-b2g/gaia-specs/blob/master/%5B2.2%5D%20Camera%20Shutter.pdf

Thanks!

Comment 7

[No-Jun Park [:njpark]]

[Blocking Requested - why for this release]:
noming since it does not match the UX spec.

Comment 8

[Tiffanie Shakespeare [:tif]]

+1 - the volume rocker should have the same behaviour as the capture button. Not doing so would make it inconsistent and cause user confusion/frustration.

Comment 9

[Hema Koka [:hema]]

(In reply to Tiffanie Shakespeare from comment #8)
> +1 - the volume rocker should have the same behaviour as the capture button.
> Not doing so would make it inconsistent and cause user confusion/frustration.

Agreed and is unfinished work on this feature. Lets get it fixed for 2.5 

Thanks
Hema

Comment 10

[Hema Koka [:hema]]

Wilsonpage: can you take this for 2.5?

Comment 11

[GitHub Autolander Bot]

Attachment: [gaia] wilsonpage:1151625 > mozilla-b2g:master

Comment 12

[Wilson Page [:wilsonpage]]

Comment on attachment 8641108 [details] [review]
[gaia] wilsonpage:1151625 > mozilla-b2g:master

I took the opportunity to improve the countdown logic to make it a bit more sane.

Comment 13

[Amy Lee [:amylee] UX]

Hi, 

I took a look at the patch and it looks good to me in that it's consistent with tapping on screen to turn the timer on/off. Thanks!

Comment 14

[Diego Marcos [:dmarcos]]

Wilson, does your patch cover bug 1165507 as well?

Comment 15

[Wilson Page [:wilsonpage]]

(In reply to Diego Marcos [:dmarcos] from comment #14)
> Wilson, does your patch cover bug 1165507 as well?

I don't think so, but it's worth trying the patch :)

Is it a race condition or have we just regressed somewhere?

Comment 16

[Wilson Page [:wilsonpage]]

Comment on attachment 8641108 [details] [review]
[gaia] wilsonpage:1151625 > mozilla-b2g:master

Switching review to dmarcos as justindarc is swamped right now.

Comment 17

[Diego Marcos [:dmarcos]]

Comment on attachment 8641108 [details] [review]
[gaia] wilsonpage:1151625 > mozilla-b2g:master

Nice cleanup. For next time, A high level description of what the problem is and how the patch solves will make the review easier and faster.

Comment 18

[Wilson Page [:wilsonpage]]

Comment on attachment 8641108 [details] [review]
[gaia] wilsonpage:1151625 > mozilla-b2g:master

https://github.com/mozilla-b2g/gaia/commit/7fc5fbacf3ad8842a3959687e3689e08c749b108

Comment 19

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest build of Flame KK 2.5 and Aires KK 2.5 by the STR in comment 0.

Actual results: Pressing the volume button during a self timer countdown can cancel the countdown.
See attachment: verified_FlameKK_v2.5.3gp
Reproduce rate: 0/10


Device: Flame KK 2.5 (Pass)
Build ID               20150823150207
Gaia Revision          cddb9f610cbe03d0ca39d81bbdce46a0fca841ab
Gaia Date              2015-08-23 03:34:38
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/4ccdd06e51d7209ba429196df7cab97bf66962db
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150823.184539
Firmware Date          Sun Aug 23 18:45:51 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5(Pass)
Build ID               20150823221817
Gaia Revision          cddb9f610cbe03d0ca39d81bbdce46a0fca841ab
Gaia Date              2015-08-23 03:34:38
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/4ccdd06e51d7209ba429196df7cab97bf66962db
Gecko Version          43.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150823.214038
Firmware Date          Sun Aug 23 21:40:46 UTC 2015
Bootloader             s1

Comment 20

[Shally Li（leave from Mozilla）]

Attachment: verified_FlameKK_v2.5.3gp