Buttons at the bottom of buglists lack an ID

RESOLVED FIXED in Bugzilla 5.0

Status

()

Bugzilla
User Interface
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Frédéric Buclin, Assigned: Frédéric Buclin)

Tracking

Bugzilla 5.0
Bug Flags:
approval +
approval5.0 +

Details

Attachments

(2 attachments)

(Assignee)

Description

3 years ago
While investigating why Selenium scripts fail in 5.0, I realized that bug 276560 prevented Selenium from correctly identifying buttons, because they have no ID. They need one.
(Assignee)

Comment 1

3 years ago
Created attachment 8588776 [details] [diff] [review]
patch, v1
Attachment #8588776 - Flags: review?(dkl)
Heh. I was just working around this issue in the test scripts by using XPATH instead. This is obviously better but wasn't sure we could get it in in time.

https://github.com/dklawren/qa/commit/53b894878b87fd2211c8b2e5a6078ca45bad7129

dkl
(Assignee)

Comment 3

3 years ago
(In reply to David Lawrence [:dkl] from comment #2)
> Heh. I was just working around this issue in the test scripts by using XPATH
> instead.

Ah no, please don't use XPATH. This is a hack, and hard to maintain.
Comment on attachment 8588776 [details] [diff] [review]
patch, v1

Review of attachment 8588776 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl
Attachment #8588776 - Flags: review?(dkl) → review+

Updated

3 years ago
Flags: approval5.0+
Flags: approval+
(Assignee)

Comment 5

3 years ago
To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
   ba69f97..9bd23db  master -> master

To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
   c2c8f77..fe7e0d0  5.0 -> 5.0
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Comment 6

3 years ago
Created attachment 8589135 [details] [diff] [review]
fix Selenium scripts

To ssh://gitolite3@git.mozilla.org/bugzilla/qa.git
   e028f4d..dc9312c  master -> master

To ssh://gitolite3@git.mozilla.org/bugzilla/qa.git
   2c08341..634547f  5.0 -> 5.0
You need to log in before you can comment on or make changes to this bug.