1151671 - Move StringHelper.ABOUT_PASSWORDS_URL to a member variable

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: Testing, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Currently, ABOUT_PASSWORDS_URL [1] is a static variable - make it a member variable (i.e. remove the static keyword and change the way it is accessed).

For the uses that extend UITest, you should be able to access StringHelper as a member variable (i.e. mStringHelper.ABOUT_PASSWORDS_URL).

To start, set up a build environment - you can see the instructions here: https://wiki.mozilla.org/Mobile/Fennec/Android

The tests you would be fixing are in our Robocop test framework, so you'll need to set that up too: https://wiki.mozilla.org/Auto-tools/Projects/Robocop

When you make changes in the mobile/android/base/tests/ directory, you should only need to recompile Robocop, not the entire browser, for these changes.

While you're developing, I recommend running just a single test at a time because the full robocop test suite takes a long time to run (at least 30 minutes).

If you need any help, you can reply to this bug, or feel free to message me on IRC - my nick is "mcomella" and you can find me in #mobile. If you need IRC setup instructions, see https://wiki.mozilla.org/IRC

Thanks and happy coding! ^_^

[1]: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/tests/StringHelper.java?rev=9892f70ad28b#35

Comment 1

[Varun Varshney]

Hi, I would like to take this up. I am currently in the process of setting up the Fennec build environment.
I searched DXR and found that StringHelper.ABOUT_PASSWORDS_URL is only used in three places in the following file:

/mobile/android/base/tests/testSystemPages.java

Apart from removing the static keyword in StringHelper class, is this the only file that I need to make changes to?

Thanks.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Varun Varshney from comment #1)
> Hi, I would like to take this up.

Sure, and welcome to Bugzilla! I'll assign you once you post a patch.

> Apart from removing the static keyword in StringHelper class, is this the
> only file that I need to make changes to?

Yep - nice digging!

Comment 3

[Prateek Arora]

Hi, is this bug still open ? I couldn't find the StringHelper.java in /mobile/android/base/tests

Infact there was no directory "tests".

However I could find directory tests and file StringHelper.java at following path :

/mobile/android/tests/browser/robocop/

But StringHelper didn't contain ABOUT_PASSWORDS_URL. 

Am I missing something ? Is the bug already solved ? 
I was looking for good first bug and this seemed easy enough. 

It would be great if anyone can point me to another similar bug.

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Prateek Arora from comment #3)
> However I could find directory tests and file StringHelper.java at following
> path :
> 
> /mobile/android/tests/browser/robocop/

Nice digging, those are the files – they were moved a few months ago.

> But StringHelper didn't contain ABOUT_PASSWORDS_URL. 
> 
> Am I missing something ? Is the bug already solved ? 

You're right, I think this was solved – searching for "about_passwords_url" produces no results. Thanks for pointing it out and sorry for the inconvenience.

> I was looking for good first bug and this seemed easy enough. 
> 
> It would be great if anyone can point me to another similar bug.

Perhaps bug 1197427?