Closed
Bug 1151735
Opened 9 years ago
Closed 5 years ago
The font panel from Reader View should disappear when selecting text from the page
Categories
(Toolkit :: Reader Mode, defect, P4)
Tracking
()
RESOLVED
FIXED
mozilla68
People
(Reporter: avaida, Assigned: sonali18317, Mentored)
References
Details
(Whiteboard: [about-reader-ui])
Attachments
(1 file)
Note: this is a follow-up issue filed for Bug 1137211. Reproducible on: Nightly 40.0a1 (2015-04-06), Aurora 39.0a2 (2015-04-06), Beta 38.0b2-build1 (20150406174117) Affected platforms: Windows 7 (x64), Ubuntu 14.04 (x64), Mac OS X 10.9.5 Steps to reproduce: 1. Launch Firefox. 2. Open a Reader View compatible page - (e.g.) http://www.bbc.com/future/story/20150402-do-colours-really-change-our-mood 3. Click the "Enter Reader View" button from the Location Bar. 4. Click the "Type controls" (Aa) button from Reader View's controls bar. 5. Select text from the page currently displayed in Reader View, using the mouse cursor. Expected result: The text is selected and the font panel is dismissed. Actual result: The text is indeed successfully selected but the font panel remains in focus. Happens when selecting images as well.
Comment 1•9 years ago
|
||
The panel disappears for me when the mousebutton is released -- it's just visible *while* selecting text. We should be listening for mousedown, not click.
Priority: -- → P4
Updated•8 years ago
|
Whiteboard: [about-reader-ui]
Assignee | ||
Comment 2•5 years ago
|
||
:Gijs, can I try solving this bug?
Updated•5 years ago
|
Assignee: nobody → sonali18317
Updated•5 years ago
|
Mentor: gijskruitbosch+bugs
Assignee | ||
Comment 3•5 years ago
|
||
Assignee | ||
Comment 4•5 years ago
|
||
:Gijs, there is a revision that the phab-bot requested. I am new to versioning. Is hg add path/to/file
, then hg commit --amend
and then arc diff
the right way to update the commit?
Comment 5•5 years ago
|
||
(In reply to sonali18317 from comment #4)
:Gijs, there is a revision that the phab-bot requested. I am new to versioning. Is
hg add path/to/file
, thenhg commit --amend
and thenarc diff
the right way to update the commit?
I think you figured this out already, but just in case: you don't need the hg add
, just the hg commit --amend
(or hg amend
), and then resubmit, yep.
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/3b996d54a151 Hide font panel when text is being selected r=Gijs
Comment 7•5 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Updated•5 years ago
|
QA Whiteboard: [good first verify]
Updated•5 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•