1151740 - JavaScript error: chrome://specialpowers/content/specialpowersAPI.js, line 1437: TypeError: cb is not a function

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

https://hg.mozilla.org/mozilla-central/file/a530b5c3b713/testing/specialpowers/content/specialpowersAPI.js#l1437

repro steps: run mochitests with the following command
|./mach mochitest-plain dom/media/test/ --start-at test_contentDuration1.html --end-at test_contentDuration2.html|

root cause:
test_contentDuration1.html calls mediaTestCleanup() in body unload function. However, after GC, all objects associated with the page are cleaned including the callback object allocated at [1].

[1] https://hg.mozilla.org/mozilla-central/file/a530b5c3b713/dom/media/test/manifest.js#l987

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: 1151740_fix_GC_callback-v1.patch

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8589425 [details] [diff] [review]
1151740_fix_GC_callback-v1.patch

Review of attachment 8589425 [details] [diff] [review]:
-----------------------------------------------------------------

Try is green: https://treeherder.mozilla.org/#/jobs?repo=try&revision=721cfa3c627e

::: dom/media/test/manifest.js
@@ +985,5 @@
>      for (i=0; i<A.length; i++) {
>        removeNodeAndSource(A[i]);
>        A[i] = null;
>      }
> +    SpecialPowers.exactGC(window, callback);

If |callback| is null, SpecialPowers.exactGC will not invoke the callback object after GC. So we can avoid the problem stated in comment 0.

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the super fast review!!

Try is green: https://treeherder.mozilla.org/#/jobs?repo=try&revision=721cfa3c627e

Please check in this bug after bug 902686 which also modifies manifest.js. Thanks.

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/778141c3e5fc

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/778141c3e5fc