Closed Bug 1151771 Opened 5 years ago Closed 5 years ago

[Shinano][Aries] USB mass storage is not working

Categories

(Firefox OS Graveyard :: GonkIntegration, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
2.2 S10 (17apr)

People

(Reporter: gerard-majax, Assigned: gerard-majax)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

60 bytes, text/x-github-pull-request
dhylands
: review+
Details | Review
STR:
 0. Enable USB Sharing with UMS

Expected:
 The sdcard is exported via UMS

Actual:
 Nothing happens
We first need to add "mass_storage" to |persist.sys.usb.config|. Then I have the feature working (a /dev/sdb is exposed to the computer) but it's not sharing anything.
(In reply to Alexandre LISSY :gerard-majax from comment #1)
> We first need to add "mass_storage" to |persist.sys.usb.config|. Then I have
> the feature working (a /dev/sdb is exposed to the computer) but it's not
> sharing anything.

And that works. My profile comes from previous devices. Code from AutoMounterSetting checks against the Settings API whether we have a specific volume allowed for UMS.

This is being checked at https://hg.mozilla.org/mozilla-central/annotate/ab0490972e1e/dom/system/gonk/AutoMounterSetting.cpp#l265

So it turns out my device previously had volumes named "sdcard", "extsdcard" and "external", while my new one has "sdcard", "sdcard1" and "usbdisk". So of course, the settings were:
 - ums.volume.sdcard.enabled: true
 - ums.volume.extsdcard.enabled: true
 - ums.volume.external.enabled: true

While it should have been:
 - ums.volume.sdcard.enabled: true
 - ums.volume.sdcard1.enabled: true
 - ums.volume.usbdisk.enabled: true

Once this is fixed, and with the appropriate persist value, then USB Mass Storage works. Only for the "sdcard1" volume of course.
Attached file Shinano common PR
Attachment #8589059 - Flags: review?(mwu)
Attachment #8589059 - Flags: review?(mwu) → review?(dhylands)
Should we also treat this as a migration issue? All my devices where I put a profile coming from a previous device expose the same issue: they lack the settings keys.
Flags: needinfo?(dhylands)
This is further complicated by the fact that you used to be able to set the individual volume controls in the settings app, but this was removed a while back.

I think that a reasonable way forward is that the preference should default to true if it doesn't exist.
Flags: needinfo?(dhylands)
Comment on attachment 8589059 [details] [review]
Shinano common PR

Looks good to me.
Attachment #8589059 - Flags: review?(dhylands) → review+
https://github.com/mozilla-b2g/device-shinano-common/commit/f4e8f3b19fedc7e08c455de93fe4cef90744c169
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [systemsfe]
Target Milestone: --- → 2.2 S10 (17apr)
Blocks: spark-device
No longer blocks: spark
You need to log in before you can comment on or make changes to this bug.