Closed Bug 1151784 Opened 5 years ago Closed 4 years ago

Enable OS X emoji panel in the message input box

Categories

(Instantbird :: Conversation, enhancement)

All
macOS
enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Instantbird 47

People

(Reporter: nhnt11, Assigned: aleth)

Details

Attachments

(1 file, 2 obsolete files)

In recent versions of OS X, you can hit Cmd+Ctrl+Space to bring up a panel that lets you insert emoji. This is enabled for example in Fx's awesomebar - we should enable it in the conversation input box too.
Attached patch Editmenu WIP (obsolete) — Splinter Review
This minimal WIP is enough to get it to work. I suppose a proper patch should include copy/paste and maybe undo/redo...
Adding an edit menu also enables the emoji panel and dictation.
Attachment #8714017 - Flags: review?(nhnt11)
Attachment #8713977 - Attachment is obsolete: true
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Alternatively, we could enable the Edit menu everywhere on OSX. Not sure it makes sense for the blist, log viewer, etc though.
Comment on attachment 8714017 [details] [diff] [review]
Add Edit menu to the conversation window on OS X

Review of attachment 8714017 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for writing the patch for this!

::: im/content/instantbird.xul
@@ +51,5 @@
> +# As menus.xul.inc, but with an Edit menu.
> +  <commandset id="maincommandset"/>
> +  <keyset id="mainkeyset"/>
> +  <menubar id="blistMenubar">
> +    <menu id="menu_edit">

Maybe add position="2" here instead of touching menus.xul? I don't feel very strongly about this, so up to you.
Attachment #8714017 - Flags: review?(nhnt11) → review+
(In reply to Nihanth Subramanya [:nhnt11] from comment #4)
> > +    <menu id="menu_edit">
> 
> Maybe add position="2" here instead of touching menus.xul? I don't feel very
> strongly about this, so up to you.

Tried that, doesn't work ;) It has to be on the overlay.
Switched to insertbefore instead of position just in case addons want to do something crazy. Insertbefore accepts a list of alternative ids, so it seems OK if an id is not present.\n\nrs?flo for checkin
Attachment #8714033 - Flags: review?(florian)
Attachment #8714017 - Attachment is obsolete: true
Comment on attachment 8714033 [details] [diff] [review]
Add Edit menu to the conversation window on OS X

Review of attachment 8714033 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me (I haven't tested the patch locally.)

::: im/content/instantbird.xul
@@ +47,5 @@
>    <script type="application/javascript" src="chrome://instantbird/content/convZoom.js"/>
>    <script type="application/javascript" src="chrome://instantbird/content/nsContextMenu.js"/>
>  
>  #ifdef XP_MACOSX
> +# As menus.xul.inc, but with an Edit menu.

You may want to add a comment in menus.xul.inc to remind that this file should be edited/kept in sync if someone ever adds something there.
Attachment #8714033 - Flags: review?(florian) → review+
https://hg.mozilla.org/comm-central/rev/6eac77f5536560efd9028d80faa8df716d20907a
Bug 1151784 - Add Edit menu to the conversation window on OS X. r=nhnt11,florian
(In reply to Florian Quèze [:florian] [:flo] from comment #7)
> You may want to add a comment in menus.xul.inc to remind that this file
> should be edited/kept in sync if someone ever adds something there.

done.
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Instantbird 47
You need to log in before you can comment on or make changes to this bug.