1151795 - The Reading List remove button from Reader View's footer is not adapting to high-contrast themes

Status: RESOLVED INVALID

(Toolkit :: Reader Mode, defect, P4)

Description

[Andrei Vaida [:avaida]]

Attachment: screenshot from Windows 7 (x64)

Reproducible on:
Nightly 40.0a1 (2015-04-06), Aurora 39.0a2 (2015-04-06), Beta 38.0b2-build1 (20150406174117)

Affected platforms:
Windows 7 (x64), Windows 8.1 (x64)

Preconditions:
* the user has a high-contrast theme set

Steps to reproduce:
1. Launch Firefox.
2. Open a Reader View compatible page - (e.g) http://www.bbc.com/news/magazine-32160231
3. Click the "Enter Reader View" button from the Location Bar.
4. Click the "Add page to Reading List" button from the Location Bar.
5. Check Reader View's footer.

Expected result:
The footer as well as the button it contains are properly adapting to high-contrast themes.

Actual result:
The button's hover styling is not adapting to high-contrast themes.

Comment 1

[Blake Winton (:bwinton) (:☕️)]

So, it seems to me that none of the in-page content (reading mode footer and reading mode toolbar) nor the sidebar is reacting to the high-contrast theme.  Now, the base page also doesn't react to high-contrast themes, so I'm not sure whether the in-page content should, but I suspect the sidebar at least should (since the bookmarks sidebar does).

Does that sound reasonable, Philipp?

Comment 2

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

(In reply to Blake Winton (:bwinton) from comment #1)
> So, it seems to me that none of the in-page content (reading mode footer and
> reading mode toolbar) nor the sidebar is reacting to the high-contrast
> theme.  Now, the base page also doesn't react to high-contrast themes, so
> I'm not sure whether the in-page content should, but I suspect the sidebar
> at least should (since the bookmarks sidebar does).
> 
> Does that sound reasonable, Philipp?

That does sound reasonable.

From the screenshot it seems like the delete button is actually regressing in high contrast mode (white text), so that should be fixed.

Comment 3

[Blake Winton (:bwinton) (:☕️)]

I could not replicate that with my current set of patches, so hopefully that'll be fixed by bug 1149649.

Comment 4

[:Gijs (he/him)]

We no longer have a delete button.