Sync tip in general preferences of developer edition doesn't wrap

NEW
Unassigned

Status

()

3 years ago
3 years ago

People

(Reporter: Gijs, Unassigned)

Tracking

38 Branch
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Split off from bug 1148024.

Both in in-content and non-in-content prefs, the tip to use sync between developer edition and "regular" Firefox doesn't wrap, which creates problems for localizers. There's a link at the end of this string, which means "just" wrapping it is not trivial. Maybe we can just move the link into the text? That'll require rehashing the string a little bit, so we can only take that fix on nightly. Brian, does this sound doable?
Forgot the needinfo. Same for Philipp - does moving the link to the end of the "Tip: ..." sentence make sense?
Flags: needinfo?(philipp)
Flags: needinfo?(bgrinstead)
We could make the »Use Sync« part the link.

I'm a bit confused though: why does a link at the end of the text make it harder to wrap?
Flags: needinfo?(philipp)
(In reply to Philipp Sackl [:phlsa] from comment #2)
> We could make the »Use Sync« part the link.
> 
> I'm a bit confused though: why does a link at the end of the text make it
> harder to wrap?

The link is currently in its own container. It's not part of the sentence.

If the sentence started wrapping, the link would not align well with the text anymore without work from us (and in that case, if the text were two lines, where would you expect the link to go - directly at the end of the second line, at the far end (to the right of the end of the first line even if the second is shorter), etc. etc.

I don't know why the link wasn't inside the text to begin with. Maybe Brian can answer that question.
(In reply to :Gijs Kruitbosch from comment #3)
> (In reply to Philipp Sackl [:phlsa] from comment #2)
> > We could make the »Use Sync« part the link.
> > 
> > I'm a bit confused though: why does a link at the end of the text make it
> > harder to wrap?
> 
> The link is currently in its own container. It's not part of the sentence.
> 
> If the sentence started wrapping, the link would not align well with the
> text anymore without work from us (and in that case, if the text were two
> lines, where would you expect the link to go - directly at the end of the
> second line, at the far end (to the right of the end of the first line even
> if the second is shorter), etc. etc.
> 
> I don't know why the link wasn't inside the text to begin with. Maybe Brian
> can answer that question.

Forwarding request to Panos, who did the sync between profiles work.
Flags: needinfo?(bgrinstead) → needinfo?(past)
I think I used a suggestion from matej, but it might just have been the best I could come up with at the time. We can definitely change it.
Flags: needinfo?(past)
Mistakenly filed against Firefox 38 and should be instead 38 Branch. Sorry for the spam. dkl
Version: Firefox 38 → 38 Branch
You need to log in before you can comment on or make changes to this bug.