Closed Bug 1151840 Opened 9 years ago Closed 9 years ago

Child abort on send signature @ mozilla::dom::PStorageChild::SendPreload(nsCString const &,unsigned int const &,nsTArray<nsString> *,nsTArray<nsString> *,nsresult *)

Categories

(Core :: DOM: Content Processes, defect)

x86
Windows
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
e10s m7+ ---
firefox41 --- fixed

People

(Reporter: tracy, Assigned: mrbkap)

References

Details

(Keywords: crash)

Crash Data

Attachments

(1 file)

Broken out per bug 1092216 comment 9

Bug 1092216 Child abort on send signature breakdown:
----------------------------------------------------
124	57.7%	mozilla::dom::PStorageChild::SendPreload(nsCString const &,unsigned int const &,nsTArray<nsString> *,nsTArray<nsString> *,nsresult *)
Blocks: 1092216
Component: IPC → DOM: Content Processes
(In reply to Jim Mathies [:jimm] from comment #2)
> *** Bug 1148384 has been marked as a duplicate of this bug. ***

Good testcases / str in this bug.
Severity: normal → critical
Assignee: nobody → mrbkap
Attached patch patch v1Splinter Review
I tried to write a test for this, but it's more difficult than I realized because we actually kick off an (asynchronous) preload as soon as we create the inner window for a new document. There's probably some way to write the test so the parent (CPOW) still wins the race, but I couldn't find it.

I did verify that if I remove the pre-preloading code, that this patch fixes the crash that was reported here.
Attachment #8617675 - Flags: review?(wmccloskey)
Attachment #8617675 - Flags: review?(wmccloskey) → review+
Crash Signature: [@ mozalloc_abort(char const* const) | NS_DebugBreak | mozilla::ipc::MessageChannel::DebugAbort(char const*, int, char const*, char const*, bool) | mozilla::ipc::MessageChannel::Send(IPC::Message*, IPC::Message*) | mozilla::dom::PStorageChild::SendPreload…
https://hg.mozilla.org/mozilla-central/rev/d947d66c49dc
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: