1151890 - Assertion failure when panning using trackpad on APZ-enabled OS X desktop build

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Attachment: lldb backtrace and frames

The PanGestureInput events are being dispatched from nsChildView.mm to the APZ on something other than the controller thread. See attached lldb backtrace and info.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Oh, this will maybe be fixed by bug 1148868?

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Workaround/patch

This fixes it for me, but I'm ok with waiting for bug 1148868 to land if you'd rather do that.

Comment 3

[Markus Stange [:mstange]]

Comment on attachment 8589166 [details] [diff] [review]
Workaround/patch

Yeah let's land this now. In bug 1148868 I'll make it conditional on the separate-event-thread pref. Thanks!

Comment 4

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ba41917b2182

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I backed this out for android reftest failures:
https://treeherder.mozilla.org/logviewer.html#?job_id=8570973&repo=mozilla-inbound
https://treeherder.mozilla.org/logviewer.html#?job_id=8570989&repo=mozilla-inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/46297000a83f

Comment 6

[Kartikaya Gupta (email:[e-mail])]

I'll reland this once the tree reopens. This patch doesn't affect Android, it's almost certainly bug 1148889 (which I co-landed with this) that caused the reftest failures.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e2e1aa665d77

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e2e1aa665d77