Closed Bug 1151908 Opened 8 years ago Closed 8 years ago

Unicode 6.3 Bidi Support - Add new Bidi classes and update character data.

Categories

(Core :: Layout: Text and Fonts, defect)

Product:
Core
Component:
Layout: Text and Fonts
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla40
Project Flags:
blocking-b2g 2.2+
Tracking Flags:
Tracking Status
firefox38 --- wontfix
firefox39 --- wontfix
firefox40 --- fixed
b2g-v2.2 --- fixed
b2g-master --- fixed

People

(Reporter: tedders1, Assigned: tedders1)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file, 1 obsolete file)

bug-1151908-bidi-classes.patch
55.44 KB, patch
smontagu
: review+
jocheng
: approval-mozilla-b2g37+
Details | Diff | Splinter Review 
Unicode 6.3 adds five new control characters for Bidi support (LRI, RLI, FSI, PDI, and ALM). There are also four new Bidi Class values that correspond to the first four characters (LRI, RLI, FSI, PDI).

We need to:

* Add the new Bidi classes to our code.

* Regenerate the character data.
Assignee: nobody → tclancy
Blocks: 922963
Attached patch bug-1151908-bidi-classes.patch (obsolete) — — Splinter Review 

        Attachment #8589266 -
        Flags: review?(smontagu)

    
  
Blocks: 1152074

    
    

    
  
Hi Simon,

Even though I'll be porting changes from ICU as much as possible, this particular patch will still be needed. Please review it when you have a moment.
Flags: needinfo?(smontagu)

    
    

    
  


  

        Attachment #8589266 -
        Attachment is obsolete: true

        Attachment #8589266 -
        Flags: review?(smontagu)

        Attachment #8594087 -
        Flags: review?(smontagu)

    
    

    
  
Comment on attachment 8594087 [details] [diff] [review]
bug-1151908-bidi-classes.patch

Review of attachment 8594087 [details] [diff] [review]:
-----------------------------------------------------------------

Sure

        Attachment #8594087 -
        Flags: review?(smontagu) → review+

    
  
Flags: needinfo?(smontagu)
Keywords: checkin-needed
Whiteboard: [systemsfe]

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/5abaed77e385
Status: NEW → RESOLVED
Closed: 8 years ago

          status-firefox40:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40

    
    

    
  
This is needed for Bug 1166203, which is a confirmed blocker for 2.2.
blocking-b2g: --- → 2.2?

    
  
Blocks: 1166203

    
    

    
  
Comment on attachment 8594087 [details] [diff] [review]
bug-1151908-bidi-classes.patch

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
RTL support for B2G (Bug 906270)

This patch is required for Bug 1166203, which is confirmed as blocking 2.2. (And probably a bunch of similar issues which haven't been spotted yet.)

User impact if declined: 
Punctuation marks will appear in the wrong place when LTR phrases appear within RTL text, or vice versa.

Testing completed: 
Green treeherder run - https://hg.mozilla.org/mozilla-central/rev/5abaed77e385

Risk to taking this patch (and alternatives if risky): 
None forseen.

String or UUID changes made by this patch:
None.

        Attachment #8594087 -
        Flags: approval-mozilla-b2g37?

    
  

        Attachment #8594087 -
        Flags: approval-mozilla-b2g37?

    
    

    
  
Comment on attachment 8594087 [details] [diff] [review]
bug-1151908-bidi-classes.patch

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
RTL support for B2G (Bug 906270)

This patch is required for Bug 1166203, which is confirmed as blocking 2.2. (And probably a bunch of similar issues which haven't been spotted yet.)

User impact if declined: 
Punctuation marks will appear in the wrong place when LTR phrases appear within RTL text, or vice versa.

Testing completed: 
Green treeherder run - https://treeherder.mozilla.org/#/jobs?repo=try&revision=5cc35d2a9d2e

Risk to taking this patch (and alternatives if risky): 
None forseen.

String or UUID changes made by this patch:
None.

        Attachment #8594087 -
        Flags: approval-mozilla-b2g37?
blocking-b2g: 2.2? → 2.2+

    
  

        Attachment #8594087 -
        Flags: approval-mozilla-b2g37? → approval-mozilla-b2g37+

    
    

    
  
Hi Ryan,

This is the first bug. Next one is bug 1157726

          You need to log in
          before you can comment on or make changes to this bug.