1151910 - testCheck2 sometimes throws java.lang.ArrayIndexOutOfBoundsException

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Testing, defect)

Description

[Geoff Brown [:gbrown] (pto Apr 11-18)]

There's no sign of a test failure here, but some logs for Talos testCheck2 (rck2) show an exception being thrown and caught.

http://ftp.mozilla.org/pub/mozilla.org/mobile/tinderbox-builds/mozilla-central-android-api-11/1428360480/mozilla-central_panda_android_test-remote-trobocheck2-bm100-tests1-panda-build102.txt.gz

16:59:25     INFO -  INFO : Exception while replaying events: java.lang.ArrayIndexOutOfBoundsException: length=2048; index=-1 [browser_output.txt]

Comment 1

[Geoff Brown [:gbrown] (pto Apr 11-18)]

I reproduced with additional logging.

09:08:13     INFO -  04-08 09:07:02.867 W/System.err( 2804): java.lang.ArrayIndexOutOfBoundsException: length=2048; index=-1
09:08:13     INFO -  04-08 09:07:02.867 W/System.err( 2804): 	at java.util.ArrayList.get(ArrayList.java:306)
09:08:13     INFO -  04-08 09:07:02.867 W/System.err( 2804): 	at org.mozilla.gecko.gfx.PanningPerfAPI.stopCheckerboardRecording(PanningPerfAPI.java:106)
09:08:13     INFO -  04-08 09:07:02.867 W/System.err( 2804): 	at org.mozilla.gecko.FennecNativeDriver.stopCheckerboardRecording(FennecNativeDriver.java:161)
09:08:13     INFO -  04-08 09:07:02.867 W/System.err( 2804): 	at org.mozilla.gecko.tests.testCheck2.testCheck2(testCheck2.java:62)
09:08:13     INFO -  04-08 09:07:02.867 W/System.err( 2804): 	at java.lang.reflect.Method.invokeNative(Native Method)
09:08:13     INFO -  04-08 09:07:02.867 W/System.err( 2804): 	at java.lang.reflect.Method.invoke(Method.java:511)
09:08:13     INFO -  04-08 09:07:02.867 W/System.err( 2804): 	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
09:08:13     INFO -  04-08 09:07:02.867 W/System.err( 2804): 	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
09:08:13     INFO -  04-08 09:07:02.867 W/System.err( 2804): 	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
09:08:13     INFO -  04-08 09:07:02.867 W/System.err( 2804): 	at org.mozilla.gecko.tests.BaseTest.runTest(BaseTest.java:135)
09:08:13     INFO -  04-08 09:07:02.867 W/System.err( 2804): 	at junit.framework.TestCase.runBare(TestCase.java:127)
09:08:13     INFO -  04-08 09:07:02.867 W/System.err( 2804): 	at junit.framework.TestResult$1.protect(TestResult.java:106)
09:08:13     INFO -  04-08 09:07:02.867 W/System.err( 2804): 	at junit.framework.TestResult.runProtected(TestResult.java:124)
09:08:13     INFO -  04-08 09:07:02.875 W/System.err( 2804): 	at junit.framework.TestResult.run(TestResult.java:109)
09:08:13     INFO -  04-08 09:07:02.875 W/System.err( 2804): 	at junit.framework.TestCase.run(TestCase.java:118)
09:08:13     INFO -  04-08 09:07:02.875 W/System.err( 2804): 	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:169)
09:08:13     INFO -  04-08 09:07:02.875 W/System.err( 2804): 	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:154)
09:08:13     INFO -  04-08 09:07:02.875 W/System.err( 2804): 	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:545)
09:08:13     INFO -  04-08 09:07:02.875 W/System.err( 2804): 	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1551)
09:08:13     INFO -  04-08 09:07:02.875 I/Robocop ( 2804): __FAILException while replaying events: java.lang.ArrayIndexOutOfBoundsException: length=2048; index=-1__FAIL

Comment 2

[Geoff Brown [:gbrown] (pto Apr 11-18)]

Attachment: guard against array index out of bounds

The stack I reported in Comment 1 was obtained from an altered testCheck2, so I'm not sure that the exceptions seen on treeherder have an identical cause, but the index and length are the same, so it seems likely. At any rate, it is possible that the array is empty; we should handle that case.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8590454 [details] [diff] [review]
guard against array index out of bounds

Review of attachment 8590454 [details] [diff] [review]:
-----------------------------------------------------------------

Lgtm

Comment 4

[Geoff Brown [:gbrown] (pto Apr 11-18)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2a7d393b7dc0

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2a7d393b7dc0