1151937 - [webvr] remove silly uuid-like things

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: remove UUIDs

WebVR deviceId/hardwareId were uuid-like things that shouldn't be.  Make them into simple integers.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8589197 [details] [diff] [review]
remove UUIDs

Review of attachment 8589197 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/vr/VRDevice.cpp
@@ +278,5 @@
>      , mTracking(false)
>    {
> +
> +    uint64_t hmdid = aHMD->GetDeviceIndex() << 8;
> +    uint64_t devid = hmdid | 0x01;

Might be worth having a comment connecting the 0x1 with the 0 above (perhaps even a define or enum). I had to look to figure out what was going on.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/deb77afd348f